Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove analyzer's deprecated analysis modes: no-implicit-casts and no-implicit-dynamic #50679

Closed
srawlins opened this issue Dec 10, 2022 · 5 comments
Closed

Remove analyzer's deprecated analysis modes: no-implicit-casts and no-implicit-dynamic #50679

srawlins opened this issue Dec 10, 2022 · 5 comments
Labels
analyzer-analysis-options area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P2 A bug or feature request we're likely to work on
Milestone
Dart 3 alpha 1

Comments

@srawlins
Copy link
Member

When these are removed, we can close issues related to them:

The new 'language' modes are documented here: https://dart.dev/guides/language/analysis-options#enabling-additional-type-checks
@srawlins srawlins added area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. analyzer-analysis-options labels Dec 10, 2022
@srawlins srawlins mentioned this issue Dec 10, 2022
Closed
@bwilkerson bwilkerson added the P2 A bug or feature request we're likely to work on label Dec 13, 2022
@bwilkerson
Copy link
Member

Do we want to set a milestone for this?

@srawlins srawlins added this to the Dart 3 alpha 1 milestone Dec 13, 2022
@srawlins
Copy link
Member Author

Good idea. Just set to Dart 3 Alpha.

@mit-mit mit-mit mentioned this issue Dec 19, 2022
Closed
16 tasks
@parlough parlough mentioned this issue Jan 4, 2023
Merged
@bartekpacia bartekpacia mentioned this issue Mar 16, 2023
Closed
@parlough
Copy link
Member

parlough commented Jun 14, 2023 •
edited
Loading

I completely missed this somehow, but it looks like this removal was reverted in 94f20d7. Perhaps reopen this so the removal doesn't get lost?

Do you have any extra context on why it was reverted?

@srawlins srawlins reopened this Jun 14, 2023
@srawlins
Copy link
Member Author

I think it was removed because some flutter customer tests referenced them.

This was referenced Jun 15, 2023
Merged
Merged
Merged
Merged
Merged
Open
Open
Merged
domesticmouse pushed a commit to flutter/put-flutter-to-work that referenced this issue Jun 15, 2023
@parlough
Move away from deprecated strong-mode analysis options (#224)
4d0803e 
I'm going through `flutter/` and other projects and removing references
to the deprecated `strong-mode` options to ease the final removal of
them.

This enables similar [analyzer language
modes](https://dart.dev/guides/language/analysis-options#enabling-additional-type-checks)
to replace them.

Issue reference: dart-lang/sdk#50679
@parlough parlough mentioned this issue Jun 16, 2023
Closed
parlough added a commit to flutter/platform_tests that referenced this issue Jun 29, 2023
@parlough
Replace deprecated strong-mode options (#21)
f1b81e9 
Updates to match the new [analysis language
options](https://dart.dev/guides/language/analysis-options#enabling-additional-type-checks)
also used in
[`flutter/flutter`](https://github.com/flutter/flutter/blob/master/analysis_options.yaml).

Issue reference: dart-lang/sdk#50679
@parlough parlough mentioned this issue Aug 16, 2023
Closed
@parlough parlough mentioned this issue Jan 17, 2024
Closed
@srawlins
Copy link
Member Author

Removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
analyzer-analysis-options area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P2 A bug or feature request we're likely to work on
Projects
None yet
Milestone
Dart 3 alpha 1
Development

No branches or pull requests
3 participants
@srawlins @bwilkerson @parlough