Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore variables named _, __, ... even when implicit-dynamic:false #26915

Closed
zoechi opened this issue Jul 19, 2016 · 1 comment
Closed

Ignore variables named _, __, ... even when implicit-dynamic:false #26915

zoechi opened this issue Jul 19, 2016 · 1 comment
Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug

Comments

@zoechi
Copy link
Contributor

zoechi commented Jul 19, 2016

These names are usually used for unused parameters.

image

In Polymer apps I have a lot of methods where a specific signature is expected by Polymer but the parameters passed by default are often not relevant:

  @reflectable
  void searchStringChanged(_, [__]) {
    if (dataView == null) {
      return;
    }
    updateFilter();
  }

adding dynamic everywhere is cumbersome for something that should communicate that it is unused

  void searchStringChanged(dynamic _, [dynamic __]) {
@bwilkerson bwilkerson added area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug labels Jul 19, 2016
@srawlins
Copy link
Member

srawlins commented Oct 9, 2023

Implicit-dynamic: false is dead. Closing as stale.

@srawlins srawlins closed this as completed Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

3 participants