Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

langauge/async_await_test seems to make following test fail on linux Dartium #26198

Closed
whesse opened this issue Apr 6, 2016 · 1 comment
Closed

langauge/async_await_test seems to make following test fail on linux Dartium #26198

whesse opened this issue Apr 6, 2016 · 1 comment
Labels
area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes.

Comments

@whesse
Copy link
Contributor

whesse commented Apr 6, 2016

We are getting a persistent pattern of tests not starting on Dartium linux, closely following successful runs of language/async_await_test/none, language/async_await_test/02, and language/async_await_test/03.

I am temporarily skipping those tests on Dartium linux, to see what effect it has on the buildbot runs.
@whesse whesse added area-dartium area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes. labels Apr 6, 2016
@whesse
Copy link
Contributor Author

whesse commented Apr 6, 2016

Also, the multitests async_await_test/02 and /03 were totally pointless. This was written using the unittest package, which we have prohibited in core tests like this, and when some subtests failed, the only way to suppress them was by making the whole thing into multitests. Then, when they stopped failing, the multitest comments were never taken out, even though no status files have any reference to them.

This is now fixed, and it is no longer a multitest.

whesse added a commit that referenced this issue Apr 7, 2016
@whesse
Remove multitests from language/async_await_test. Skip on linux x64 d…
0bad11c 
…artium

BUG=#26198
BUG=#22695
R=kustermann@google.com

Review URL: https://codereview.chromium.org/1864973003 .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@terrylucas @whesse