Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test of await, language/await_future_test, times out on Chrome 41 on macos. #22695

Closed
whesse opened this issue Mar 6, 2015 · 11 comments
Closed
Assignees
Labels
browser-chrome os-osx P3 A lower priority bug or feature request type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) web-dart2js

Comments

@whesse
Copy link
Contributor

whesse commented Mar 6, 2015

FAILED: dart2js-chrome release_ia32 language/await_future_test
Expected: Pass
Actual: Timeout
CommandOutput[dart2js]:

There are no delays or timers in the test, so it almost certainly is hanging when it times out. This seems quite bad, and it is in the new await code in dart2js, so marking as high priority.

It failed (timed out) in 3 runs out of 10 on the buildbot.

@floitschG
Copy link
Contributor

Set owner to @sigurdm.

@floitschG
Copy link
Contributor

Fwiw I tried it locally and had 50 successful runs.

@kasperl
Copy link

kasperl commented Mar 20, 2015

Added this to the 1.10 milestone.

@sigurdm
Copy link
Contributor

sigurdm commented Apr 17, 2015

Bill - can you help me setting up a reproduction?
As far as I remember this has only been seen failing on the bots.


cc @whesse.

@whesse whesse added Type-Defect P1 A high priority bug; for example, a single project is unusable or has many test failures web-dart2js browser-chrome labels Apr 17, 2015
@whesse whesse added this to the 1.10 milestone Apr 17, 2015
@sigurdm
Copy link
Contributor

sigurdm commented Jun 4, 2015

I looked through the last 100 logs of the mac-chrome bot (with a script). And it seems to not time out anymore. Is it a newer Chrome on the bot?

@whesse
Copy link
Contributor Author

whesse commented Jun 8, 2015

Yes, the debug log (which can be clicked on in the buildbot) says it is on version 43. We can probably re-enable the tests.

http://build.chromium.org/p/client.dart/builders/dart2js-chrome-mac10.9-be/builds/942/steps/annotated_steps/logs/debuglog

@sigurdm
Copy link
Contributor

sigurdm commented Jun 8, 2015

Great! - I will reenable the tests.

sigurdm added a commit that referenced this issue Jun 8, 2015
It seems that the new chrome does not trigger the bug.

BUG= #22695
R=whesse@google.com

Review URL: https://codereview.chromium.org//1149633010
@sigurdm
Copy link
Contributor

sigurdm commented Jun 8, 2015

Nope - my script was looking in the wrong places. The tests are still failing.

@kevmoo kevmoo modified the milestones: 1.12, 1.10 Jun 29, 2015
@whesse
Copy link
Contributor Author

whesse commented Aug 5, 2015

We are having lots of timeouts on many tests on Chrome on macos. Here is a list of the most recent. So it is not all async/await support. And these are not tests that are taking a long time normally, when they do pass.

html/custom/attribute_changed_callback_test/fully_supported
html/custom/created_callback_test
html/custom/entered_left_view_test/disconnected_subtree
html/indexeddb_3_test
html/indexeddb_3_test
html/indexeddb_4_test
language/asyncstar_yield_test
lib/async/catch_errors18_test
lib/async/stream_event_transformed_test
lib/async/stream_event_transformed_test

This one does take 20s normally, but fails with 1 minute.
lib/convert/streamed_conversion_json_encode1_test

@whesse
Copy link
Contributor Author

whesse commented Aug 5, 2015

Tracked in meta-issue #23980

@sigmundch sigmundch modified the milestones: 1.12, 1.13 Aug 17, 2015
@sigmundch sigmundch removed this from the 1.13 milestone Sep 24, 2015
@sigmundch sigmundch added P3 A lower priority bug or feature request and removed P1 A high priority bug; for example, a single project is unusable or has many test failures labels Dec 8, 2015
@kevmoo kevmoo added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) and removed triaged labels Mar 1, 2016
@whesse
Copy link
Contributor Author

whesse commented Apr 6, 2016

I am removing the two remaining timeout status lines for this issue (language/async_await_test and language/await_future_test), as the scattered timeouts are being tracked in #23980, and there is no evidence these timeouts have a different cause than the other, unsuppressed ones. Closing this issue, leaving #23980 open.

@whesse whesse closed this as completed Apr 6, 2016
whesse added a commit that referenced this issue Apr 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser-chrome os-osx P3 A lower priority bug or feature request type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) web-dart2js
Projects
None yet
Development

No branches or pull requests

6 participants