-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test of await, language/await_future_test, times out on Chrome 41 on macos. #22695
Comments
Set owner to @sigurdm. |
Fwiw I tried it locally and had 50 successful runs. |
Added this to the 1.10 milestone. |
Bill - can you help me setting up a reproduction? cc @whesse. |
I looked through the last 100 logs of the mac-chrome bot (with a script). And it seems to not time out anymore. Is it a newer Chrome on the bot? |
Yes, the debug log (which can be clicked on in the buildbot) says it is on version 43. We can probably re-enable the tests. |
Great! - I will reenable the tests. |
It seems that the new chrome does not trigger the bug. BUG= #22695 R=whesse@google.com Review URL: https://codereview.chromium.org//1149633010
Nope - my script was looking in the wrong places. The tests are still failing. |
We are having lots of timeouts on many tests on Chrome on macos. Here is a list of the most recent. So it is not all async/await support. And these are not tests that are taking a long time normally, when they do pass. html/custom/attribute_changed_callback_test/fully_supported This one does take 20s normally, but fails with 1 minute. |
Tracked in meta-issue #23980 |
I am removing the two remaining timeout status lines for this issue (language/async_await_test and language/await_future_test), as the scattered timeouts are being tracked in #23980, and there is no evidence these timeouts have a different cause than the other, unsuppressed ones. Closing this issue, leaving #23980 open. |
…artium BUG=#26198 BUG=#22695 R=kustermann@google.com Review URL: https://codereview.chromium.org/1864973003 .
FAILED: dart2js-chrome release_ia32 language/await_future_test
Expected: Pass
Actual: Timeout
CommandOutput[dart2js]:
There are no delays or timers in the test, so it almost certainly is hanging when it times out. This seems quite bad, and it is in the new await code in dart2js, so marking as high priority.
It failed (timed out) in 3 runs out of 10 on the buildbot.
The text was updated successfully, but these errors were encountered: