Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the item argument to Match dynamic again #163

Merged
merged 2 commits into from
Dec 29, 2020
Merged

Make the item argument to Match dynamic again #163

merged 2 commits into from
Dec 29, 2020

Commits on Dec 28, 2020

  1. Make the item argument to Match dynamic again 

    This argument had been implicitly dynamic. #162 made it `Object?` which
can cause analysis errors that are otherwise hidden due to implicit
casts. Any classes which implement `Matcher` and override `match` could
omit the argument type, which mean to inherit from the parent. When that
became `Object?` the cast to some other type which could have been
implicit coming from `dynamic` must now be explicit.
    @natebosch
    natebosch committed Dec 28, 2020
    Configuration menu
    Copy the full SHA
    453622c View commit details
    Browse the repository at this point in the history

  2. Also describeMismatch

    @natebosch
    natebosch committed Dec 28, 2020
    Configuration menu
    Copy the full SHA
    072ab81 View commit details
    Browse the repository at this point in the history