Make the item argument to Match dynamic again #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This argument had been implicitly dynamic. #162 made it `Object?` which can cause analysis errors that are otherwise hidden due to implicit casts. Any classes which implement `Matcher` and override `match` could omit the argument type, which mean to inherit from the parent. When that became `Object?` the cast to some other type which could have been implicit coming from `dynamic` must now be explicit.
srawlins
approved these changes
Dec 29, 2020
natebosch
added a commit
that referenced
this pull request
Dec 29, 2020
Similar to #163 changing the argument type from implicit `dynamic` to `Object` for implementations that don't specify the type since inference will pick the argument type from the overridden method.
natebosch
added a commit
that referenced
this pull request
Dec 29, 2020
Similar to #163 changing the argument type from implicit `dynamic` to `Object` for implementations that don't specify the type since inference will pick the argument type from the overridden method.
mosuem
pushed a commit
to dart-lang/test
that referenced
this pull request
Oct 17, 2024
This argument had been implicitly dynamic. dart-lang/matcher#162 made it `Object?` which can cause analysis errors that are otherwise hidden due to implicit casts. Any classes which implement `Matcher` and override `match` could omit the argument type, which mean to inherit from the parent. When that became `Object?` the cast to some other type which could have been implicit coming from `dynamic` must now be explicit.
mosuem
pushed a commit
to dart-lang/test
that referenced
this pull request
Oct 17, 2024
Similar to dart-lang/matcher#163 changing the argument type from implicit `dynamic` to `Object` for implementations that don't specify the type since inference will pick the argument type from the overridden method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This argument had been implicitly dynamic. #162 made it
Object?whichcan cause analysis errors that are otherwise hidden due to implicit
casts. Any classes which implement
Matcherand overridematchcouldomit the argument type, which inherits from the parent. When that
became
Object?the cast to some other type coming fromdynamicmust now be explicit.