Skip to content
This repository has been archived by the owner on Nov 20, 2024. It is now read-only.

Make the auto-generated options list more visible #384

Merged
merged 1 commit into from
Feb 3, 2017
Merged

Conversation

filiph
Copy link
Contributor

@filiph filiph commented Jan 26, 2017

Currently, the link to options/options.html is hard to find, even if you know what you're looking for. This change:

  • Makes the link much more visible
  • Clearly explains how to use it.

Currently, the link to `options/options.html` is hard to find, even if you know what you're looking for. This change:

- Makes the link much more visible
- Clearly explains how to use it.
@pq
Copy link
Member

pq commented Feb 3, 2017

LGTM. Thanks!

(And sorry for the slow review!)

@pq pq merged commit 8c8e103 into master Feb 3, 2017
some lints will be enabled in practice, but this list should provide a
[analysis options](https://pub.dartlang.org/packages/analyzer)
or through the
[.analysis-options file](https://www.dartlang.org/guides/language/analysis-options#the-analysis-options-file).
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't that be analysis_options.yaml?
From what I got this is now the preferred name.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. That's the front-runner but there is a bit of debate still (dart-lang/sdk#28385). Maybe best to just ref to the dartlang doc and treat that as the source of truth (and trust that it will get updated once the dust settles around the proposed name change). I'll follow-up with a PR.

Thanks!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#396

👍

@filiph
Copy link
Contributor Author

filiph commented Mar 6, 2017

Hi, I noticed this hasn't landed on the official site yet. @pq, can you hit publish on that?

@filiph filiph deleted the promote-lint-list branch March 6, 2017 18:25
@pq
Copy link
Member

pq commented Mar 7, 2017

In general, I try and keep the docs in sync with the latest public release and so have been waiting to ship. I opened a tracking bug for the next release (#477) and hope we can push that out in the next few days. Feel free to chime in if you have any thing else you'd like to see landed there.

Thanks!

@pq pq mentioned this pull request Mar 7, 2017
11 tasks
@filiph
Copy link
Contributor Author

filiph commented Mar 7, 2017

Oh! Got it. I forgot this thing generates the whole documentation in one go, not just the homepage.

Looking forward to 0.1.30!

@pq
Copy link
Member

pq commented Apr 7, 2017

Done!

@filiph
Copy link
Contributor Author

filiph commented Apr 7, 2017

Thanks!

Oh no, the generated site says:

An auto-generated list enabling all options is providedhere.

Not sure why that's the case. provided and here are on separate lines.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants