-
Notifications
You must be signed in to change notification settings - Fork 169
Make the auto-generated options list more visible #384
Conversation
Currently, the link to `options/options.html` is hard to find, even if you know what you're looking for. This change: - Makes the link much more visible - Clearly explains how to use it.
LGTM. Thanks! (And sorry for the slow review!) |
some lints will be enabled in practice, but this list should provide a | ||
[analysis options](https://pub.dartlang.org/packages/analyzer) | ||
or through the | ||
[.analysis-options file](https://www.dartlang.org/guides/language/analysis-options#the-analysis-options-file). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't that be analysis_options.yaml
?
From what I got this is now the preferred name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. That's the front-runner but there is a bit of debate still (dart-lang/sdk#28385). Maybe best to just ref to the dartlang doc and treat that as the source of truth (and trust that it will get updated once the dust settles around the proposed name change). I'll follow-up with a PR.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Hi, I noticed this hasn't landed on the official site yet. @pq, can you hit publish on that? |
In general, I try and keep the docs in sync with the latest public release and so have been waiting to ship. I opened a tracking bug for the next release (#477) and hope we can push that out in the next few days. Feel free to chime in if you have any thing else you'd like to see landed there. Thanks! |
Oh! Got it. I forgot this thing generates the whole documentation in one go, not just the homepage. Looking forward to 0.1.30! |
Done! |
Thanks! Oh no, the generated site says:
Not sure why that's the case. |
Currently, the link to
options/options.html
is hard to find, even if you know what you're looking for. This change: