0.1.30 Release Plan

[pq]

Punch list for a 0.1.30 release.

Plan items

• update invariant_booleans docs (Expect.listEquals produces incorrect message #476)
• fix false positive for unnecessary_lambdas (Specification of Expect.setEqual() is incomplete or misleading #473)
• land use_initializing_formals_when_possible (Weird parser error #475)
• do some rule renaming for consistency (search box match result presentation issues (was: dart editor - no way to navigate to a class) #489)
• update changelist, pubspec
• update AUTHORS (Impossible to define field of parameterized type with function type #511)
• land invariant_booleans perf fixes (Value types (deep immutability) #501)

Releasing

• tag release (tag/0.1.30)
• publish package (Crash on startup #438)
• publish docs ( Make the auto-generated options list more visible linter#384 (comment) )
• update DEPS (dart editor should show unrecognized types in a different color #491)

@alexeieleusis, @JPaulsen : are there any changes you have pending that are close to landing?

[alexeieleusis]

dart-lang/linter#475 should land soon and we found some false positives for unnecessary_lambdas, should land soon too.

I think we should wait to fix the false positives because it certainly can change the programs in unintended ways. Or at least disable it.

[alexeieleusis]

I should have said @a14n found some false positives, not us. Thank you!

[alexeieleusis]

#57466 is the issue to fix.

[pq]

Thanks @alexeieleusis! Updated punch list.

[pq]

Given the ongoing conversation on #57466, should we maybe just disable unnecessary_lambdas for this release? We can follow-up with another as soon as we feel good about a proper fix.

@JPaulsen @alexeieleusis ?

[JPaulsen]

@pq I have the final fix almost ready, I think I will have it before 12:30 to check (actually I finished implementing it, I am writing more tests to have better test coverage)

[pq]

Nice. Thanks for the update @JPaulsen !

[pq]

Updated punchlist with a new task to do some naming normalization. (I was starting on a changelist and noticed that we have some names that don't play that well with our existing ones.) I'll follow-up with a PR.

[alexeieleusis]

Awesome, thank you @pq .

[alexeieleusis]

@JPaulsen has a very interesting idea regarding performance of invariant_booleans and also has some progress on it, probably not worth delaying the release, but soon might be fixed.

[pq]

In the home stretch...

Unless folks feel strongly, I'd like to cut the branch. We can follow-up quickly with a fresh patch if needed. (FWIW: I'd like to get back into a monthly -- at least -- release cadence.)

cc @alexeieleusis @JPaulsen @srawlins

[alexeieleusis]

@JPaulsen seems to be done with the performance fix for invariant_boolean, it is no longer a slow lint, I would say we wait for it, is almost ready for review.

[pq]

Sounds good @alexeieleusis. Thanks @JPaulsen! 👍

[pq]

Quick update: the plan of record is to cut this from dart-lang/linter@f451f4c (@JPaulsen 's excellent invariant_booleans fix). 🎂

[pq]

Actually, bumping forward to 2d2bd8d (for @a14n 's fix to do_not_check_for_null_in_equality_operators).

EDIT: going back to dart-lang/linter@f451f4c, to let new rules bake a bit.

[pq]

At long last, landed!