[Wildcard Variables] Disable the no_wildcard_variable_uses lint in >=3.6
#5072
Comments
kallentu
changed the title
no_wildcard_variable_uses lint in 3.6no_wildcard_variable_uses lint in 3.6
|
We can't actually remove the lint until we stop supporting any language version prior to the version in which wildcard variables is shipped. The reason is that users could still have code that opts back to 3.5 or earlier and might still want the lint enable for that code so that they don't make it harder to migrate that code to the latest version. What we can do instead is disable the lint for any library in which the feature is enabled. When we get closer to dropping support for pre-3.6 versions we can deprecate the lint, and then after a period of time we can actually remove it. (We don't want to deprecate it in 3.6 because that would be annoying for users that still need it for not-yet-migrated code.) |
Ah, this should be the proper action item then. That sounds good to me. |
kallentu
changed the title
no_wildcard_variable_uses lint in 3.6no_wildcard_variable_uses lint in >=3.6
|
We've got a bit of precedent here and a few other lints that get short-circuited based on the presence of a language feature so I agree that's a good way to go here. Sorry for the late reply! |
Fixes: dart-lang/linter#5072 Change-Id: I926ab733df2a8caaa3574fd4284618683780b37e Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/381920 Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Commit-Queue: Phil Quitslund <pquitslund@google.com>
|
Fixed w/ dart-lang/sdk@5be7c56. |
The wildcard variables feature will cover errors that this lint is triggering on for
_.We should disable the lint for any library in which the feature is enabled (>= 3.6, once the flag is enabled).
cc. @pq
The text was updated successfully, but these errors were encountered: