Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Wildcard Variables] Linter Support #4969

Open
Tracked by #55673
pq opened this issue May 13, 2024 · 0 comments
Open
Tracked by #55673

[Wildcard Variables] Linter Support #4969

pq opened this issue May 13, 2024 · 0 comments
Assignees
@pq
Labels
meta new-language-feature P2 A bug or feature request we're likely to work on set-core Affects a rule in the core Dart rule set set-flutter Affects a rule in the recommended Flutter rule set set-recommended Affects a rule in the recommended Dart rule set type-enhancement A request for a change that isn't a bug

Comments

@pq
Copy link
Member

pq commented May 13, 2024 •
edited
Loading

A meta-issue to discuss and track work on linter support for wildcard variables.

Existing Lints

  • [Wildcard Variables] evaluate support for always_declare_return_types
  • [Wildcard Variables] evaluate support for always_put_control_body_on_new_line
  • [Wildcard Variables] evaluate support for always_put_required_named_parameters_first
  • [Wildcard Variables] evaluate support for always_specify_types
  • [Wildcard Variables] evaluate support for always_use_package_imports
  • [Wildcard Variables] evaluate support for annotate_overrides
  • [Wildcard Variables] evaluate support for annotate_redeclares [experimental]
  • [Wildcard Variables] evaluate support for avoid_annotating_with_dynamic
  • [Wildcard Variables] evaluate support for avoid_bool_literals_in_conditional_expressions
  • [Wildcard Variables] evaluate support for avoid_catches_without_on_clauses
  • [Wildcard Variables] evaluate support for avoid_catching_errors
  • [Wildcard Variables] evaluate support for avoid_classes_with_only_static_members
  • [Wildcard Variables] evaluate support for avoid_double_and_int_checks
  • [Wildcard Variables] evaluate support for avoid_dynamic_calls
  • [Wildcard Variables] evaluate support for avoid_empty_else
  • [Wildcard Variables] evaluate support for avoid_equals_and_hash_code_on_mutable_classes
  • [Wildcard Variables] evaluate support for avoid_escaping_inner_quotes
  • [Wildcard Variables] evaluate support for avoid_field_initializers_in_const_classes
  • [Wildcard Variables] support for avoid_final_parameters #5045
  • [Wildcard Variables] evaluate support for avoid_function_literals_in_foreach_calls
  • [Wildcard Variables] evaluate support for avoid_implementing_value_types
  • [Wildcard Variables] evaluate support for avoid_init_to_null
  • [Wildcard Variables] evaluate support for avoid_js_rounded_ints
  • [Wildcard Variables] evaluate support for avoid_multiple_declarations_per_line
  • [Wildcard Variables] evaluate support for avoid_null_checks_in_equality_operators
  • [Wildcard Variables] evaluate support for avoid_positional_boolean_parameters
  • [Wildcard Variables] evaluate support for avoid_print
  • [Wildcard Variables] evaluate support for avoid_private_typedef_functions
  • [Wildcard Variables] evaluate support for avoid_redundant_argument_values
  • [Wildcard Variables] evaluate support for avoid_relative_lib_imports
  • [Wildcard Variables] support for avoid_renaming_method_parameters #5025
  • [Wildcard Variables] evaluate support for avoid_return_types_on_setters
  • [Wildcard Variables] evaluate support for avoid_returning_null_for_void
  • [Wildcard Variables] evaluate support for avoid_returning_this
  • [Wildcard Variables] evaluate support for avoid_setters_without_getters
  • [Wildcard Variables] support for avoid_shadowing_type_parameters #5046
  • [Wildcard Variables] evaluate support for avoid_single_cascade_in_expression_statements
  • [Wildcard Variables] evaluate support for avoid_slow_async_io
  • [Wildcard Variables] evaluate support for avoid_type_to_string
  • [Wildcard Variables] support for avoid_types_as_parameter_names #5051
  • [Wildcard Variables] evaluate support for avoid_types_on_closure_parameters
  • [Wildcard Variables] evaluate support for avoid_unnecessary_containers
  • [Wildcard Variables] support for avoid_unused_constructor_parameters
  • [Wildcard Variables] evaluate support for avoid_void_async
  • [Wildcard Variables] evaluate support for avoid_web_libraries_in_flutter
  • [Wildcard Variables] evaluate support for await_only_futures
  • [Wildcard Variables] evaluate support for camel_case_extensions
  • [Wildcard Variables] evaluate support for camel_case_types
  • [Wildcard Variables] evaluate support for cancel_subscriptions
  • [Wildcard Variables] evaluate support for cascade_invocations
  • [Wildcard Variables] evaluate support for cast_nullable_to_non_nullable
  • [Wildcard Variables] evaluate support for close_sinks
  • [Wildcard Variables] evaluate support for collection_methods_unrelated_type
  • [Wildcard Variables] evaluate support for combinators_ordering
  • [Wildcard Variables] evaluate support for comment_references
  • [Wildcard Variables] evaluate support for conditional_uri_does_not_exist
  • [Wildcard Variables] evaluate support for constant_identifier_names
  • [Wildcard Variables] evaluate support for control_flow_in_finally
  • [Wildcard Variables] evaluate support for curly_braces_in_flow_control_structures
  • [Wildcard Variables] evaluate support for dangling_library_doc_comments
  • [Wildcard Variables] evaluate support for depend_on_referenced_packages
  • [Wildcard Variables] evaluate support for deprecated_consistency
  • [Wildcard Variables] evaluate support for deprecated_member_use_from_same_package
  • [Wildcard Variables] evaluate support for diagnostic_describe_all_properties
  • [Wildcard Variables] evaluate support for directives_ordering
  • [Wildcard Variables] evaluate support for discarded_futures
  • [Wildcard Variables] evaluate support for document_ignores
  • [Wildcard Variables] evaluate support for do_not_use_environment
  • [Wildcard Variables] support for empty_catches
  • [Wildcard Variables] evaluate support for empty_constructor_bodies
  • [Wildcard Variables] evaluate support for empty_statements
  • [Wildcard Variables] evaluate support for eol_at_end_of_file
  • [Wildcard Variables] evaluate support for erase_dart_type_extension_types
  • [Wildcard Variables] evaluate support for exhaustive_cases
  • [Wildcard Variables] evaluate support for file_names
  • [Wildcard Variables] evaluate support for flutter_style_todos
  • [Wildcard Variables] evaluate support for hash_and_equals
  • [Wildcard Variables] evaluate support for implementation_imports
  • [Wildcard Variables] evaluate support for implicit_call_tearoffs
  • [Wildcard Variables] evaluate support for implicit_reopen [experimental]
  • [Wildcard Variables] evaluate support for invalid_case_patterns [experimental]
  • [Wildcard Variables] evaluate support for join_return_with_assignment
  • [Wildcard Variables] evaluate support for invalid_runtime_check_with_js_interop_types
  • [Wildcard Variables] evaluate support for leading_newlines_in_multiline_strings
  • [Wildcard Variables] evaluate support for library_annotations
  • [Wildcard Variables] evaluate support for library_names
  • [Wildcard Variables] evaluate support for library_prefixes
  • [Wildcard Variables] evaluate support for library_private_types_in_public_api
  • [Wildcard Variables] evaluate support for lines_longer_than_80_chars
  • [Wildcard Variables] evaluate support for literal_only_boolean_expressions
  • [Wildcard Variables] evaluate support for matching_super_parameters
  • [Wildcard Variables] evaluate support for missing_code_block_language_in_doc_comment
  • [Wildcard Variables] evaluate support for missing_whitespace_between_adjacent_strings
  • [Wildcard Variables] evaluate support for no_adjacent_strings_in_list
  • [Wildcard Variables] evaluate support for no_default_cases [experimental]
  • [Wildcard Variables] evaluate support for no_duplicate_case_values
  • [Wildcard Variables] support for no_leading_underscores_for_library_prefixes #5039
  • [Wildcard Variables] support for no_leading_underscores_for_local_identifiers #5040
  • [Wildcard Variables] evaluate support for no_literal_bool_comparisons
  • [Wildcard Variables] evaluate support for no_logic_in_create_state
  • [Wildcard Variables] evaluate support for no_runtimeType_toString
  • [Wildcard Variables] evaluate support for no_self_assignments
  • [Wildcard Variables] support for no_wildcard_variable_uses
  • [Wildcard Variables] support for non_constant_identifier_names #5048
  • [Wildcard Variables] evaluate support for noop_primitive_operations
  • [Wildcard Variables] evaluate support for null_check_on_nullable_type_parameter
  • [Wildcard Variables] evaluate support for null_closures
  • [Wildcard Variables] evaluate support for omit_local_variable_types
  • [Wildcard Variables] evaluate support for omit_obvious_local_variable_types [experimental]
  • [Wildcard Variables] evaluate support for one_member_abstracts
  • [Wildcard Variables] evaluate support for only_throw_errors
  • [Wildcard Variables] evaluate support for overridden_fields
  • [Wildcard Variables] evaluate support for package_api_docs
  • [Wildcard Variables] evaluate support for package_names
  • [Wildcard Variables] evaluate support for package_prefixed_library_names
  • [Wildcard Variables] support for parameter_assignments #5041
  • [Wildcard Variables] evaluate support for prefer_adjacent_string_concatenation
  • [Wildcard Variables] evaluate support for prefer_asserts_in_initializer_lists
  • [Wildcard Variables] evaluate support for prefer_asserts_with_message
  • [Wildcard Variables] evaluate support for prefer_collection_literals
  • [Wildcard Variables] evaluate support for prefer_conditional_assignment
  • [Wildcard Variables] evaluate support for prefer_const_constructors
  • [Wildcard Variables] evaluate support for prefer_const_constructors_in_immutables
  • [Wildcard Variables] evaluate support for prefer_const_declarations
  • [Wildcard Variables] evaluate support for prefer_const_literals_to_create_immutables
  • [Wildcard Variables] evaluate support for prefer_constructors_over_static_methods
  • [Wildcard Variables] evaluate support for prefer_contains
  • [Wildcard Variables] evaluate support for prefer_double_quotes
  • [Wildcard Variables] evaluate support for prefer_expression_function_bodies
  • [Wildcard Variables] evaluate support for prefer_final_fields
  • [Wildcard Variables] evaluate support for prefer_final_in_for_each
  • [Wildcard Variables] support for prefer_final_locals #5042
  • [Wildcard Variables] support for prefer_final_parameters #5044
  • [Wildcard Variables] evaluate support for prefer_for_elements_to_map_fromIterable
  • [Wildcard Variables] evaluate support for prefer_foreach
  • [Wildcard Variables] evaluate support for prefer_function_declarations_over_variables
  • [Wildcard Variables] evaluate support for prefer_generic_function_type_aliases
  • [Wildcard Variables] evaluate support for prefer_if_elements_to_conditional_expressions
  • [Wildcard Variables] evaluate support for prefer_if_null_operators
  • [Wildcard Variables] evaluate support for prefer_initializing_formals
  • [Wildcard Variables] evaluate support for prefer_inlined_adds
  • [Wildcard Variables] evaluate support for prefer_int_literals
  • [Wildcard Variables] evaluate support for prefer_interpolation_to_compose_strings
  • [Wildcard Variables] evaluate support for prefer_is_empty
  • [Wildcard Variables] evaluate support for prefer_is_not_empty
  • [Wildcard Variables] evaluate support for prefer_is_not_operator
  • [Wildcard Variables] evaluate support for prefer_iterable_whereType
  • [Wildcard Variables] evaluate support for prefer_mixin
  • [Wildcard Variables] evaluate support for prefer_null_aware_method_calls
  • [Wildcard Variables] evaluate support for prefer_null_aware_operators
  • [Wildcard Variables] evaluate support for prefer_relative_imports
  • [Wildcard Variables] evaluate support for prefer_single_quotes
  • [Wildcard Variables] evaluate support for prefer_spread_collections
  • [Wildcard Variables] evaluate support for prefer_typing_uninitialized_variables
  • [Wildcard Variables] evaluate support for prefer_void_to_null
  • [Wildcard Variables] evaluate support for provide_deprecation_message
  • [Wildcard Variables] evaluate support for public_member_api_docs
  • [Wildcard Variables] evaluate support for recursive_getters
  • [Wildcard Variables] evaluate support for require_trailing_commas
  • [Wildcard Variables] evaluate support for secure_pubspec_urls
  • [Wildcard Variables] evaluate support for sized_box_for_whitespace
  • [Wildcard Variables] evaluate support for sized_box_shrink_expand
  • [Wildcard Variables] evaluate support for slash_for_doc_comments
  • [Wildcard Variables] evaluate support for sort_child_properties_last
  • [Wildcard Variables] evaluate support for sort_constructors_first
  • [Wildcard Variables] evaluate support for sort_pub_dependencies
  • [Wildcard Variables] evaluate support for sort_unnamed_constructors_first
  • [Wildcard Variables] evaluate support for test_types_in_equals
  • [Wildcard Variables] evaluate support for throw_in_finally
  • [Wildcard Variables] evaluate support for tighten_type_of_initializing_formals
  • [Wildcard Variables] evaluate support for type_annotate_public_apis
  • [Wildcard Variables] evaluate support for type_init_formals
  • [Wildcard Variables] evaluate support for type_literal_in_constant_pattern
  • [Wildcard Variables] evaluate support for unawaited_futures
  • [Wildcard Variables] evaluate support for unintended_html_in_doc_comment
  • [Wildcard Variables] evaluate support for unnecessary_await_in_return
  • [Wildcard Variables] evaluate support for unnecessary_brace_in_string_interps
  • [Wildcard Variables] evaluate support for unnecessary_breaks
  • [Wildcard Variables] evaluate support for unnecessary_const
  • [Wildcard Variables] evaluate support for unnecessary_constructor_name
  • [Wildcard Variables] support for unnecessary_final #5043
  • [Wildcard Variables] evaluate support for unnecessary_getters_setters
  • [Wildcard Variables] evaluate support for unnecessary_lambdas
  • [Wildcard Variables] evaluate support for unnecessary_late
  • [Wildcard Variables] evaluate support for unnecessary_library_directive
  • [Wildcard Variables] evaluate support for unnecessary_library_name
  • [Wildcard Variables] evaluate support for unnecessary_new
  • [Wildcard Variables] evaluate support for unnecessary_null_aware_assignments
  • [Wildcard Variables] evaluate support for unnecessary_null_aware_operator_on_extension_on_nullable
  • [Wildcard Variables] evaluate support for unnecessary_null_checks [experimental]
  • [Wildcard Variables] evaluate support for unnecessary_null_in_if_null_operators
  • [Wildcard Variables] evaluate support for unnecessary_nullable_for_final_variable_declarations
  • [Wildcard Variables] evaluate support for unnecessary_overrides
  • [Wildcard Variables] evaluate support for unnecessary_parenthesis
  • [Wildcard Variables] evaluate support for unnecessary_raw_strings
  • [Wildcard Variables] evaluate support for unnecessary_statements
  • [Wildcard Variables] evaluate support for unnecessary_string_escapes
  • [Wildcard Variables] evaluate support for unnecessary_string_interpolations
  • [Wildcard Variables] evaluate support for unnecessary_this
  • [Wildcard Variables] evaluate support for unnecessary_to_list_in_spreads
  • [Wildcard Variables] evaluate support for unreachable_from_main
  • [Wildcard Variables] evaluate support for unrelated_type_equality_checks
  • [Wildcard Variables] evaluate support for unsafe_html
  • [Wildcard Variables] evaluate support for use_build_context_synchronously
  • [Wildcard Variables] evaluate support for use_colored_box
  • [Wildcard Variables] evaluate support for use_decorated_box
  • [Wildcard Variables] evaluate support for use_enums
  • [Wildcard Variables] evaluate support for use_full_hex_values_for_flutter_colors
  • [Wildcard Variables] evaluate support for use_function_type_syntax_for_parameters
  • [Wildcard Variables] evaluate support for use_if_null_to_convert_nulls_to_bools
  • [Wildcard Variables] evaluate support for use_is_even_rather_than_modulo
  • [Wildcard Variables] evaluate support for use_key_in_widget_constructors
  • [Wildcard Variables] evaluate support for use_late_for_private_fields_and_variables [experimental]
  • [Wildcard Variables] evaluate support for use_named_constants
  • [Wildcard Variables] evaluate support for use_raw_strings
  • [Wildcard Variables] evaluate support for use_rethrow_when_possible
  • [Wildcard Variables] evaluate support for use_setters_to_change_properties
  • [Wildcard Variables] evaluate support for use_string_buffers
  • [Wildcard Variables] evaluate support for use_string_in_part_of_directives
  • [Wildcard Variables] evaluate support for use_super_parameters [experimental]
  • [Wildcard Variables] evaluate support for use_test_throws_matchers
  • [Wildcard Variables] evaluate support for use_to_and_as_if_applicable
  • [Wildcard Variables] evaluate support for valid_regexps
  • [Wildcard Variables] evaluate support for void_checks

New Lints
@pq pq added type-enhancement A request for a change that isn't a bug P2 A bug or feature request we're likely to work on new-language-feature labels May 13, 2024
@pq pq self-assigned this May 13, 2024
@kallentu kallentu mentioned this issue May 10, 2024
Open
20 tasks
@pq pq added the meta label May 13, 2024
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Jul 10, 2024
@pq
[wildcards] unnecessary_final tests
f4a5b2d 
Fixes #55920

See also dart-lang/linter#4969

Change-Id: Id70834d6b71a268ed6037203124ae10a5eb1d592
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/375082
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
@github-actions github-actions bot added set-recommended Affects a rule in the recommended Dart rule set set-core Affects a rule in the core Dart rule set set-flutter Affects a rule in the recommended Flutter rule set labels Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pq pq

Labels
meta new-language-feature P2 A bug or feature request we're likely to work on set-core Affects a rule in the core Dart rule set set-flutter Affects a rule in the recommended Flutter rule set set-recommended Affects a rule in the recommended Dart rule set type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pq