-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support creating output directories that only contain symlinks #1647
Conversation
…e to configure symlinks or not
In terms of performance, when testing with the |
Tried running this with angulars _tests and looks like web tests don't work 🤦♂️ . Investigating now... but will require a fix in package:test it looks like. |
build_runner/CHANGELOG.md
Outdated
|
||
### Breaking Changes | ||
|
||
- The `RunnerAssetReader` interface now requires that you implement the new |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe call out that most users don't have any reason to implement this interface and are not likely impacted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed offline - we should hold off on committing this until we've gotten another publish of build_runner that supports Dart 2.
cc @natebosch ok I updated this with the changes we talked about. There is now a |
Looks like symlinks don't work as expected on windows even though there is supposedly support for linking individual files according to windows docs, the VM always ends up creating a directory symlink. |
Filed dart-lang/sdk#33966 |
@@ -17,6 +17,8 @@ import '../package_graph/package_graph.dart'; | |||
import 'build_environment.dart'; | |||
import 'create_merged_dir.dart'; | |||
|
|||
final _logger = new Logger('IOEnvironment'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to include this at
var knownNames = const [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Closes #1242
Added a new
--symlink
option, which is defaulted to true fortest
but no other commands.This is unfortunately a breaking change in build_runner and build_runner_core as it required adding a new interface which must be implemented by any
RunnerAssetReader
, which is an exposed class from both of these packages.