Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --symlink flag which changes the -o directory to be all symlinks #1242

Closed
jakemac53 opened this issue Apr 4, 2018 · 3 comments
Closed

Add --symlink flag which changes the -o directory to be all symlinks #1242

jakemac53 opened this issue Apr 4, 2018 · 3 comments
Assignees
@jakemac53
Labels
type-enhancement A request for a change that isn't a bug type-performance

Comments

@jakemac53
Copy link
Contributor

This would speed up running tests or development scenarios where people need a merged output dir.
@jakemac53 jakemac53 added the type-enhancement A request for a change that isn't a bug label Apr 4, 2018
@jakemac53
Copy link
Contributor Author

To clarify, if we use symlinks not only will the first creation of the merged dir be faster but we also should be able to leave in place any existing links. We only have to delete any links to deleted files and add new ones for new files.

@matanlurey
Copy link
Contributor

Huge +1 (for compatible systems, at least).

I'd love to see this be the default for POSIX (with an opt-out as --no-symlinks)

@jakemac53
Copy link
Contributor Author

I think we will need to start this as opt-in only, since the main supported use case of the output directory is for deployment.

For the test command we will automagically use the symlink option though, which is the other code path that is affected by this (and the main motivation for fixing it too).

@jakemac53 jakemac53 self-assigned this Jul 11, 2018
This was referenced Jul 11, 2018
Merged
Merged
jakemac53 added a commit that referenced this issue Jul 24, 2018
@jakemac53
Support creating output directories that only contain symlinks (#1647)
6066471 
Closes #1242

Added a new `--symlink` option, which is defaulted to true for `test` but no other commands.

This is unfortunately a breaking change in build_runner and build_runner_core as it required adding a new interface which must be implemented by any `RunnerAssetReader`, which is an exposed class from both of these packages.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jakemac53 jakemac53

Labels
type-enhancement A request for a change that isn't a bug type-performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@matanlurey @jakemac53