Add openOptionsPage binding

fix brave/browser-laptop#4700 Auditors: @bridiver, @jonathansampson
darkdh · Oct 28, 2016 · e1368f3 · e1368f3
1 parent 9b2f304
commit e1368f3
Show file tree

Hide file tree

Showing 6 changed files with 31 additions and 0 deletions.
diff --git a/atom/atom_resources.grd b/atom/atom_resources.grd
@@ -36,6 +36,8 @@
       <include name="IDR_ATOM_WINDOWS_BINDINGS_JS" file="common\api\resources\windows_bindings.js" type="BINDATA" />
 
       <include name="IDR_ATOM_APP_BINDINGS_JS" file="common\api\resources\app_bindings.js" type="BINDATA" />
+
+      <include name="IDR_ATOM_RUNTIME_EXTRA_BINDINGS_JS" file="common\api\resources\runtime_extra_bindings.js" type="BINDATA" />
     </includes>
   </release>
 </grit>
diff --git a/atom/common/api/resources/_api_features.json b/atom/common/api/resources/_api_features.json
@@ -54,6 +54,10 @@
     "channel": "stable",
     "contexts": ["blessed_extension"]
   },
+  "runtimeExtra": {
+    "channel": "stable",
+    "contexts": ["blessed_extension"]
+  },
   "windows": {
     "channel": "stable",
     "contexts": ["blessed_extension"]

diff --git a/atom/common/api/resources/context_menus_bindings.js b/atom/common/api/resources/context_menus_bindings.js
@@ -13,3 +13,14 @@ var binding = {
 }
 
 exports.binding = binding;
+
+// TODO (Anthony): Move this to separated binding
+var runtime = require('runtime').binding
+var tabs = require('tabs').binding
+
+runtime.openOptionsPage = function (cb) {
+  let manifest = runtime.getManifest()
+  let optionsPageURL = runtime.getURL(manifest.options_page)
+  tabs.create({url: optionsPageURL})
+  cb && cb()
+}
diff --git a/atom/common/api/resources/runtime_extra_bindings.js b/atom/common/api/resources/runtime_extra_bindings.js
@@ -0,0 +1,9 @@
+var runtime = require('runtime').binding
+var tabs = require('tabs').binding
+
+runtime.openOptionsPage = function (cb) {
+  let manifest = runtime.getManifest()
+  let optionsPageURL = runtime.getURL(manifest.options_page)
+  tabs.create({url: optionsPageURL})
+  cb && cb()
+}
diff --git a/atom/renderer/extensions/atom_extensions_dispatcher_delegate.cc b/atom/renderer/extensions/atom_extensions_dispatcher_delegate.cc
@@ -73,6 +73,9 @@ void AtomExtensionsDispatcherDelegate::PopulateSourceMap(
                              IDR_ATOM_WINDOWS_BINDINGS_JS);
   source_map->RegisterSource("app",
                              IDR_ATOM_APP_BINDINGS_JS);
+
+  source_map->RegisterSource("runtimeExtra",
+                             IDR_ATOM_RUNTIME_EXTRA_BINDINGS_JS);
 }
 
 void AtomExtensionsDispatcherDelegate::RequireAdditionalModules(

diff --git a/extensions.gyp b/extensions.gyp
@@ -46,6 +46,7 @@
         'atom/common/api/resources/ipc_bindings.js',
         'atom/common/api/resources/ipc_utils.js',
         'atom/common/api/resources/privacy_bindings.js',
+        'atom/common/api/resources/runtime_extra_bindings.js',
         'atom/common/api/resources/tabs_bindings.js',
         'atom/common/api/resources/web_frame.json',
         'atom/common/api/resources/web_frame_bindings.js',
@@ -68,6 +69,7 @@
             'atom/common/api/resources/ipc_bindings.js',
             'atom/common/api/resources/ipc_utils.js',
             'atom/common/api/resources/privacy_bindings.js',
+            'atom/common/api/resources/runtime_extra_bindings.js',
             'atom/common/api/resources/tabs_bindings.js',
             'atom/common/api/resources/web_frame.json',
             'atom/common/api/resources/web_frame_bindings.js',