Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Pocket: Repair chrome.runtime.openOptionsPage #4700

Closed
jonathansampson opened this issue Oct 12, 2016 · 1 comment
Closed

Pocket: Repair chrome.runtime.openOptionsPage #4700

jonathansampson opened this issue Oct 12, 2016 · 1 comment
Assignees
@darkdh
Labels
feature/extensions
Milestone
0.12.8dev

Comments

@jonathansampson
Copy link
Collaborator

Describe the issue you encountered:
Calling chrome.runtime.openOptionsPage() results in an exception:

Unchecked runtime.lastError while running runtime.openOptionsPage:
Could not create an options page.

See this example.

Expected behavior:
Calling chrome.runtime.openOptionsPage() results in a new tab opening to the extensions options page, as provided in the manifest.json.

Platform: Windows 10
Brave Version: 0.12.4

Any related issues:
@jonathansampson jonathansampson added this to the 0.12.6dev milestone Oct 12, 2016
@bbondy bbondy modified the milestones: 0.12.7dev, 0.12.6dev, 0.12.8dev Oct 18, 2016
@darkdh darkdh self-assigned this Oct 26, 2016
darkdh added a commit to darkdh/electron that referenced this issue Oct 28, 2016
@darkdh
Add openOptionsPage binding
e1368f3 
fix brave/browser-laptop#4700

Auditors: @bridiver, @jonathansampson
@darkdh darkdh mentioned this issue Oct 28, 2016
Closed
@darkdh
Copy link
Member

darkdh commented Oct 29, 2016

closed by brave/muon@00f3723

@darkdh darkdh closed this as completed Oct 29, 2016
This was referenced Nov 2, 2016
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@darkdh darkdh

Labels
feature/extensions
Projects
None yet
Milestone
0.12.8dev
Development

Successfully merging a pull request may close this issue.

Add openOptionsPage binding darkdh/electron
3 participants
@jonathansampson @bbondy @darkdh