-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Spring Boot enhancements, Sring Data Repository, Testcontainers #1089
Conversation
This depends on this: #1085 so please help us to merge that one first |
9dbdadc
to
886f0d8
Compare
@salaboy I have addressed all your comments. Do let me know how to you want to proceed with Spring Boot related folders, do we rename them as per @ThomasVitale proposal like:
|
...pringboot/sdk-spring-core/src/main/java/io/dapr/spring/data/AbstractDaprKeyValueAdapter.java
Outdated
Show resolved
Hide resolved
...pringboot/sdk-spring-core/src/main/java/io/dapr/spring/data/AbstractDaprKeyValueAdapter.java
Outdated
Show resolved
Hide resolved
...pring-core/src/main/java/io/dapr/spring/data/repository/query/DaprPredicateQueryCreator.java
Outdated
Show resolved
Hide resolved
sdk-springboot/sdk-spring-core/src/test/java/io/dapr/spring/data/AbstractBaseIT.java
Outdated
Show resolved
Hide resolved
sdk-springboot/sdk-spring-core/src/test/java/io/dapr/spring/data/AbstractPostgreSQLBaseIT.java
Outdated
Show resolved
Hide resolved
...pringboot/sdk-spring-core/src/test/java/io/dapr/spring/data/MySQLDaprKeyValueTemplateIT.java
Outdated
Show resolved
Hide resolved
...t/sdk-spring-core/src/test/java/io/dapr/spring/data/repository/DaprKeyValueRepositoryIT.java
Outdated
Show resolved
Hide resolved
...gboot-autoconfigure/src/test/java/io/dapr/spring/boot/autoconfigure/BaseIntegrationTest.java
Outdated
Show resolved
Hide resolved
...re/src/test/java/io/dapr/spring/boot/autoconfigure/pubsub/DaprPubSubAutoConfigurationIT.java
Outdated
Show resolved
Hide resolved
...autoconfigure/src/test/java/io/dapr/spring/boot/autoconfigure/pubsub/TestRestController.java
Outdated
Show resolved
Hide resolved
sdk-springboot/sdk-springboot-starters/sdk-springboot-starter/pom.xml
Outdated
Show resolved
Hide resolved
096ead9
to
5ec1a29
Compare
.../main/java/io/dapr/spring/boot/autoconfigure/statestore/DaprStateStoreAutoConfiguration.java
Outdated
Show resolved
Hide resolved
@cicoyle @artursouza this test here: https://github.com/dapr/java-sdk/actions/runs/10578048505/job/29307323653?pr=1089
But the assertion is done on contains "CallOptions deadline exceeded after" , which in my opinion is causing the flakiness as Daprd (the runtime) is not consistently returning the same error. @cicoyle maybe you can help me to investigate what is the difference between "context deadline exceeded" and "CallOptions deadline exceeded after" In my experience so far, this test is returning "CallOptions deadline exceeded after" one every 5 attempts. |
@salaboy, unless @artursouza and @cicoyle have a different opinion, I think asserting the I have adjusted the test, please take a look and let me know your thoughts. |
@artursouza and @cicoyle the build is 🟢. I will need your help with Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty close. Have a few comments. Thanks a lot for your contribution.
...gure/src/main/java/io/dapr/spring/boot/autoconfigure/client/DaprClientBuilderConfigurer.java
Outdated
Show resolved
Hide resolved
...-spring/dapr-spring-boot-testcontainers/src/main/java/io/dapr/testcontainers/DaprModule.java
Outdated
Show resolved
Hide resolved
dapr-spring/dapr-spring-data/src/main/java/io/dapr/spring/data/DaprKeyValueAdapterResolver.java
Outdated
Show resolved
Hide resolved
sdk-tests/src/test/java/io/dapr/it/methodinvoke/grpc/MethodInvokeIT.java
Show resolved
Hide resolved
The violation is coming from MySQL Connector/J 8.2.0 Community for using GPL 2.0. Is there an alternative we can use? |
...-spring/dapr-spring-boot-testcontainers/src/main/java/io/dapr/testcontainers/DaprModule.java
Outdated
Show resolved
Hide resolved
sdk-tests/src/test/java/io/dapr/it/testcontainers/DaprContainerTest.java
Show resolved
Hide resolved
I have created a |
22380ff
to
287be6c
Compare
@artursouza and @salaboy you can check the SpotBugs failures here: https://github.com/dapr/java-sdk/actions/runs/10601809365/job/29382433463?pr=1089#step:16:3094. This is after I have removed SpotBugs exclude from I don't think having those two exclusion rules for SpotBugs will lead to issues. As I already mentioned most of the classes that we inject via dependency injections are Spring Beans and there is nothing we can do about it. Please let me know if you are OK with bringing back the SpotBugs exclusions. |
sdk-tests/src/test/java/io/dapr/it/spring/data/DaprKeyValueRepositoryIT.java
Outdated
Show resolved
Hide resolved
sdk-tests/src/test/java/io/dapr/it/spring/data/DaprKeyValueRepositoryIT.java
Outdated
Show resolved
Hide resolved
sdk-tests/src/test/java/io/dapr/it/spring/data/DaprKeyValueRepositoryIT.java
Outdated
Show resolved
Hide resolved
sdk-tests/src/test/java/io/dapr/it/spring/data/DaprKeyValueRepositoryIT.java
Show resolved
Hide resolved
sdk-tests/src/test/java/io/dapr/it/spring/data/DaprKeyValueRepositoryIT.java
Show resolved
Hide resolved
ed2d07b
to
57ac962
Compare
@artursouza thanks a lot for your review. I have addressed or answered all your comments. I have provided an example regarding SpotBugs failures. If everything looks good, could you please approve and merge. Thank you. |
@artursouza @salaboy @cicoyle the build is 🟢 I have addressed all the comments. Whenever you have a chance could you please take a look. Thank you 🙇 |
@artursouza looking at the spotbug issues in the link provided I think there is no need to action anything, and having those exclude rules makes sense here.. Do you recommend maybe more concrete exclusion rules? I was looking at the approach suggested here: https://stackoverflow.com/questions/74127307/spring-dependency-injection-marked-unsafe-by-spotbugs but as some users mentioned, it is not worth doing that when this is for spring boot usage. |
Signed-off-by: Artur Ciocanu <ciocanu@adobe.com>
Signed-off-by: Artur Ciocanu <ciocanu@adobe.com>
Signed-off-by: Artur Ciocanu <ciocanu@adobe.com>
@artursouza I have addressed all the review comments. The build is 🟢. I am not sure what's wrong with Thank you 🙇 ! |
Description
This PR adds support for:
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1088
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: