Addressing review comments, remove explicit exposed port for containers

Signed-off-by: Artur Ciocanu <ciocanu@adobe.com>
dapr · Aug 29, 2024 · b5824bc · b5824bc
1 parent 57ac962
commit b5824bc
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 6 deletions.
diff --git a/sdk-tests/src/test/java/io/dapr/it/spring/data/DaprKeyValueRepositoryIT.java b/sdk-tests/src/test/java/io/dapr/it/spring/data/DaprKeyValueRepositoryIT.java
@@ -62,7 +62,6 @@ public class DaprKeyValueRepositoryIT {
       .withDatabaseName("dapr_db_repository")
       .withUsername("postgres")
       .withPassword("password")
-      .withExposedPorts(5432)
       .withNetwork(DAPR_NETWORK);
 
   @Container
@@ -77,7 +76,6 @@ public class DaprKeyValueRepositoryIT {
 
   @DynamicPropertySource
   static void daprProperties(DynamicPropertyRegistry registry) {
-    DAPR_CONTAINER.start();
     registry.add("dapr.grpc.port", DAPR_CONTAINER::getGrpcPort);
     registry.add("dapr.http.port", DAPR_CONTAINER::getHttpPort);
   }

diff --git a/sdk-tests/src/test/java/io/dapr/it/spring/data/MySQLDaprKeyValueTemplateIT.java b/sdk-tests/src/test/java/io/dapr/it/spring/data/MySQLDaprKeyValueTemplateIT.java
@@ -76,7 +76,6 @@ public class MySQLDaprKeyValueTemplateIT {
       .withDatabaseName("dapr_db")
       .withUsername("mysql")
       .withPassword("password")
-      .withExposedPorts(3306)
       .withNetwork(DAPR_NETWORK)
       .waitingFor(MYSQL_WAIT_STRATEGY);
 
@@ -92,7 +91,6 @@ public class MySQLDaprKeyValueTemplateIT {
 
   @DynamicPropertySource
   static void daprProperties(DynamicPropertyRegistry registry) {
-    DAPR_CONTAINER.start();
     registry.add("dapr.grpc.port", DAPR_CONTAINER::getGrpcPort);
     registry.add("dapr.http.port", DAPR_CONTAINER::getHttpPort);
   }

diff --git a/sdk-tests/src/test/java/io/dapr/it/spring/data/PostgreSQLDaprKeyValueTemplateIT.java b/sdk-tests/src/test/java/io/dapr/it/spring/data/PostgreSQLDaprKeyValueTemplateIT.java
@@ -63,7 +63,6 @@ public class PostgreSQLDaprKeyValueTemplateIT {
       .withDatabaseName("dapr_db")
       .withUsername("postgres")
       .withPassword("password")
-      .withExposedPorts(5432)
       .withNetwork(DAPR_NETWORK);
 
   @Container
@@ -78,7 +77,6 @@ public class PostgreSQLDaprKeyValueTemplateIT {
 
   @DynamicPropertySource
   static void daprProperties(DynamicPropertyRegistry registry) {
-    DAPR_CONTAINER.start();
     registry.add("dapr.grpc.port", DAPR_CONTAINER::getGrpcPort);
     registry.add("dapr.http.port", DAPR_CONTAINER::getHttpPort);
   }