Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-10736 Cart: Add support for UCX tcp transport #9615

Merged
merged 1 commit into from
Jul 15, 2022
Merged

DAOS-10736 Cart: Add support for UCX tcp transport #9615

merged 1 commit into from
Jul 15, 2022

Conversation

soumagne
Copy link
Collaborator

@soumagne soumagne commented Jul 5, 2022

No description provided.

@soumagne
DAOS-10736 Cart: Add support for UCX tcp transport
e1116df 
Signed-off-by: Jerome Soumagne <jerome.soumagne@intel.com>
daosbuild1
daosbuild1 reviewed Jul 5, 2022
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

jgmoore-or
jgmoore-or approved these changes Jul 5, 2022
View reviewed changes
Copy link
Contributor

@jgmoore-or jgmoore-or left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These code changes are sufficient to enable ucx+tcp within CaRT, but the control plane currently supports only IB protocols. A change to the control plane to allow tcp as a ucx protocol will be require.

@soumagne
Copy link
Collaborator Author

soumagne commented Jul 5, 2022 •
edited
Loading

@jgmoore-or yes the control plane changes were actually already done in #9214 I was just late on checking in that change.

@frostedcmos frostedcmos requested a review from jolivier23 July 15, 2022 18:12
@jolivier23 jolivier23 merged commit 3c7200a into master Jul 15, 2022
@jolivier23 jolivier23 deleted the soumagne/ucx_tcp branch July 15, 2022 18:28
jolivier23 pushed a commit that referenced this pull request Jul 18, 2022
@soumagne
DAOS-10736 Cart: Add support for UCX tcp transport (#9615) (#9719)
2d42ff6 
Signed-off-by: Jerome Soumagne <jerome.soumagne@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daosbuild1 daosbuild1 daosbuild1 left review comments

@frostedcmos frostedcmos frostedcmos approved these changes

@jgmoore-or jgmoore-or jgmoore-or approved these changes

@jolivier23 jolivier23 Awaiting requested review from jolivier23

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@soumagne @jgmoore-or @frostedcmos @daosbuild1 @jolivier23