Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-10736 control: Improve UCX transport support #9214

Merged
merged 1 commit into from
Jun 1, 2022
Merged

Conversation

kjacque
Copy link
Contributor

@kjacque kjacque commented Jun 1, 2022

  • Add support for ucx+all alias.
  • Stop scanning non-network components. For now we will limit
    scanning to the infiniband (ib) and tcp components.
  • For tcp, don't attempt to build a multirail device name.

Signed-off-by: Kris Jacque kristin.jacque@intel.com

- Add support for ucx+all alias.
- Stop scanning non-network components. For now we will limit
  scanning to the infiniband (ib) and tcp components.
- For tcp, don't attempt to build a multirail device name.

Signed-off-by: Kris Jacque <kristin.jacque@intel.com>
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@kjacque kjacque changed the title DAOS-WIP control: Improve UCX transport support DAOS-10736 control: Improve UCX transport support Jun 1, 2022
@kjacque kjacque self-assigned this Jun 1, 2022
@kjacque kjacque marked this pull request as ready for review June 1, 2022 16:15
@kjacque kjacque requested a review from a team as a code owner June 1, 2022 16:15
@kjacque kjacque requested review from mjmac, knard38, tanabarr and soumagne and removed request for a team June 1, 2022 16:15
Copy link
Contributor

@knard38 knard38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go code seems OK for me.
However, not enough experience with UCX and libfabric to validate the consequences for the management of libfabric providers.

@mjmac mjmac merged commit 288e9f4 into master Jun 1, 2022
@mjmac mjmac deleted the kjacque/ucx-tcp branch June 1, 2022 17:54
kjacque added a commit that referenced this pull request Jun 2, 2022
- Add support for ucx+all alias.
- Stop scanning non-network components. For now we will limit
  scanning to the infiniband (ib) and tcp components.
- For tcp, don't attempt to build a multirail device name.

Signed-off-by: Kris Jacque <kristin.jacque@intel.com>
jolivier23 pushed a commit that referenced this pull request Jun 3, 2022
- Add support for ucx+all alias.
- Stop scanning non-network components. For now we will limit
  scanning to the infiniband (ib) and tcp components.
- For tcp, don't attempt to build a multirail device name.

Signed-off-by: Kris Jacque <kristin.jacque@intel.com>
eberroca pushed a commit that referenced this pull request Jun 22, 2022
- Add support for ucx+all alias.
- Stop scanning non-network components. For now we will limit
  scanning to the infiniband (ib) and tcp components.
- For tcp, don't attempt to build a multirail device name.

Signed-off-by: Kris Jacque <kristin.jacque@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants