Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-7203 control: Add histogram support to Prometheus exporter #5382

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

DAOS-7203 control: Add histogram support to Prometheus exporter #5382

wants to merge 1 commit into from

Conversation

mjmac
Copy link
Contributor

@mjmac mjmac commented Apr 8, 2021 •
edited
Loading

Switch the object I/O counters to histograms in order to capture
per-I/O size distributions in addition to total amounts. Update
the Prometheus exporter to support passthrough histograms from
native DAOS telemetry format.

@mjmac mjmac self-assigned this Apr 8, 2021
daosbuild1
daosbuild1 reviewed Apr 8, 2021
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

daosbuild1
daosbuild1 reviewed Apr 10, 2021
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

daosbuild1
daosbuild1 reviewed Apr 17, 2021
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

daosbuild1
daosbuild1 reviewed Apr 23, 2021
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@github-actions GitHub Actions
Copy link

Bug-tracker data:
Ticket title is 'Create standard DAOS dashboards for Grafana'
Status is 'Resolved'
Labels: 'rel20_TB3,rel20_TB4'
https://daosio.atlassian.net/browse/DAOS-7203

1 similar comment
@github-actions GitHub Actions
Copy link

Bug-tracker data:
Ticket title is 'Create standard DAOS dashboards for Grafana'
Status is 'Resolved'
Labels: 'rel20_TB3,rel20_TB4'
https://daosio.atlassian.net/browse/DAOS-7203

@mjmac
Copy link
Contributor Author

mjmac commented Feb 17, 2024 •
edited
Loading

Screenshot 2024-02-16 at 20 33 45

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 17, 2024 •
edited
Loading

Functional on EL 9 Test Results (old)

135 tests  ±0   130 ✅  - 1   1h 24m 30s ⏱️ - 7m 9s
 41 suites ±0     4 💤 ±0 
 41 files   ±0     0 ❌ ±0   1 🔥 +1 

For more details on these errors, see this check.

Results for commit 427bb06. ± Comparison against base commit 9894532.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 17, 2024 •
edited
Loading

Functional on EL 8.8 Test Results (old)

135 tests  ±0   130 ✅  - 1   1h 34m 45s ⏱️ + 5m 40s
 41 suites ±0     4 💤 ±0 
 41 files   ±0     0 ❌ ±0   1 🔥 +1 

For more details on these errors, see this check.

Results for commit 427bb06. ± Comparison against base commit 9894532.

♻️ This comment has been updated with latest results.

@mjmac mjmac mentioned this pull request Feb 20, 2024
Closed
18 tasks
@github-actions GitHub Actions
Copy link

Bug-tracker data:
Ticket title is 'Create standard DAOS dashboards for Grafana'
Status is 'Resolved'
Labels: 'rel20_TB3,rel20_TB4'
https://daosio.atlassian.net/browse/DAOS-7203

@mjmac mjmac changed the base branch from master to mjmac/agent_prom February 20, 2024 23:20
@github-actions GitHub Actions
Copy link

Bug-tracker data:
Ticket title is 'Create standard DAOS dashboards for Grafana'
Status is 'Resolved'
Labels: 'rel20_TB3,rel20_TB4'
https://daosio.atlassian.net/browse/DAOS-7203

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 21, 2024 •
edited
Loading

Functional Hardware Large Test Results (old)

64 tests  ±0   64 ✅ ±0   28m 16s ⏱️ -26s
14 suites ±0    0 💤 ±0 
14 files   ±0    0 ❌ ±0 

Results for commit 427bb06. ± Comparison against base commit 9894532.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 21, 2024 •
edited
Loading

Functional Hardware Medium Test Results (old)

130 tests  ±0   103 ✅  - 1   2h 12m 10s ⏱️ + 2m 18s
 34 suites ±0    26 💤 ±0 
 34 files   ±0     1 ❌ +1 

For more details on these failures, see this check.

Results for commit 427bb06. ± Comparison against base commit 9894532.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 21, 2024 •
edited
Loading

Functional Hardware Medium Verbs Provider Test Results (old)

55 tests  ±0   54 ✅ ±0   4h 7m 30s ⏱️ -1s
 7 suites ±0    1 💤 ±0 
 7 files   ±0    0 ❌ ±0 

Results for commit 427bb06. ± Comparison against base commit 9894532.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

Bug-tracker data:
Ticket title is 'Create standard DAOS dashboards for Grafana'
Status is 'Resolved'
Labels: 'rel20_TB3,rel20_TB4'
https://daosio.atlassian.net/browse/DAOS-7203

@github-actions GitHub Actions
Copy link

Bug-tracker data:
Ticket title is 'Create standard DAOS dashboards for Grafana'
Status is 'Resolved'
Labels: 'rel20_TB3,rel20_TB4'
https://daosio.atlassian.net/browse/DAOS-7203

@mjmac
DAOS-7203 control: Add histogram support to Prometheus exporter
b74fdf0 
Switch the object I/O counters to histograms in order to capture
per-I/O size distributions in addition to total amounts. Update
the Prometheus exporter to support passthrough histograms from
native DAOS telemetry format.

Features: telemetry
Required-githooks: true
Change-Id: I7842cc48a107ec0ba0ec93472fb6684db7394d30
Signed-off-by: Michael MacDonald <mjmac@google.com>
@mjmac mjmac changed the base branch from mjmac/agent_prom to master May 3, 2024 15:53
@github-actions GitHub Actions
Copy link

github-actions bot commented May 3, 2024

Bug-tracker data:
Ticket title is 'Create standard DAOS dashboards for Grafana'
Status is 'Resolved'
Labels: 'rel20_TB3,rel20_TB4'
https://daosio.atlassian.net/browse/DAOS-7203

@github-actions GitHub Actions
Copy link

github-actions bot commented May 3, 2024

Ticket title is 'Create standard DAOS dashboards for Grafana'
Status is 'Resolved'
Labels: 'rel20_TB3,rel20_TB4'
https://daosio.atlassian.net/browse/DAOS-7203

@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-5382/11/execution/node/1177/log

@daltonbohning
Copy link
Contributor

FYI - I think the dkey_akey_enum_punch.py failures are being fixed in #14301

@daltonbohning
Copy link
Contributor

FYI - I think the dkey_akey_enum_punch.py failures are being fixed in #14301

Actually, sorry. That looks like a different issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daosbuild1 daosbuild1 daosbuild1 left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

@mjmac mjmac

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mjmac @daosbuild1 @daltonbohning