Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-15797 test: fix nvme/object.py read_an_array #14301

Merged
merged 1 commit into from
May 8, 2024
Merged

DAOS-15797 test: fix nvme/object.py read_an_array #14301

merged 1 commit into from
May 8, 2024

Conversation

daltonbohning
Copy link
Contributor

Move test_hints argument to read_an_obj only, not read_an_array

Test-tag: RbldWithIO RbldReadArrayTest RbldBasic DaosObjectQuery PoolEvictTest DkeyAkeyEnumPunch ObjFetchBadParam
Skip-unit-tests: true
Skip-fault-injection-test: true

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@daltonbohning daltonbohning self-assigned this May 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2024 •
edited
Loading

Ticket title is 'nvme/object.py:NvmeObject.test_nvme_object_multiple_pools - read_an_array() got an unexpected keyword argument 'test_hints''
Status is 'In Progress'
Labels: 'ci_impact,weekly_test'
https://daosio.atlassian.net/browse/DAOS-15797

@daltonbohning daltonbohning force-pushed the dbohning/daos-15797 branch from 1eecd28 to 12efe0c Compare May 3, 2024 13:42
@daltonbohning daltonbohning mentioned this pull request May 3, 2024
Merged
@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14301/2/execution/node/809/log

@daltonbohning daltonbohning force-pushed the dbohning/daos-15797 branch from 12efe0c to ff7ddb0 Compare May 3, 2024 20:21
@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14301/3/execution/node/809/log

@daltonbohning daltonbohning force-pushed the dbohning/daos-15797 branch from ff7ddb0 to 33d8676 Compare May 6, 2024 20:33
@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14301/4/execution/node/784/log

@daltonbohning
DAOS-15797 test: fix nvme/object.py read_an_array
e76d041 
Move test_hints argument to read_an_obj only, not read_an_array

Test-tag: RbldWithIO RbldReadArrayTest RbldBasic DaosObjectQuery PoolEvictTest DkeyAkeyEnumPunch ObjFetchBadParam NvmeObject
Skip-unit-tests: true
Skip-fault-injection-test: true

Required-githooks: true

Signed-off-by: Dalton Bohning <dalton.bohning@intel.com>
@daltonbohning daltonbohning force-pushed the dbohning/daos-15797 branch from 33d8676 to e76d041 Compare May 7, 2024 14:26
@daltonbohning daltonbohning marked this pull request as ready for review May 8, 2024 14:25
@daltonbohning daltonbohning requested review from a team as code owners May 8, 2024 14:25
@daltonbohning
Copy link
Contributor Author

Affected tests passed: https://build.hpdd.intel.com/job/daos-stack/job/daos/view/change-requests/job/PR-14301/5/testReport/

@phender phender requested a review from a team May 8, 2024 15:01
@phender phender added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label May 8, 2024
@phender phender merged commit 91bfbbb into master May 8, 2024
43 checks passed
@phender phender deleted the dbohning/daos-15797 branch May 8, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phender phender phender approved these changes

@mjean308 mjean308 mjean308 approved these changes

Assignees

@daltonbohning daltonbohning

Labels
forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@daltonbohning @daosbuild1 @mjean308 @phender