Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-16268 test: daos_test/rebuild.py tests not reporting failed pool creation #15110

Open
wants to merge 41 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 40 commits
Commits
Show all changes
41 commits
Select commit Hold shift + click to select a range
f43ae41
recommit
dinghwah Apr 21, 2023
704278b
DAOS-15396 test: Coverage Report on Master March 2024
dinghwah Mar 8, 2024
5bb6091
retore pool_security_test_base.py
dinghwah Mar 8, 2024
65e360b
restore pool_security_test_base.py
dinghwah Apr 24, 2024
7521808
recommit
dinghwah Apr 21, 2023
b71da8c
DAOS-15396 test: Coverage Report on Master March 2024
dinghwah Mar 8, 2024
68d36ef
retore pool_security_test_base.py
dinghwah Mar 8, 2024
9fc0350
restore pool_security_test_base.py
dinghwah Apr 24, 2024
f6f7b4b
Restore pool_security_test_base.py
dinghwah May 23, 2024
a532b57
DAOS-16268 test: daos_test/rebuild.py tests not reporting failed pool…
dinghwah Sep 10, 2024
96c8d28
recommit
dinghwah Apr 21, 2023
ddb417b
DAOS-15396 test: Coverage Report on Master March 2024
dinghwah Mar 8, 2024
7b1826c
retore pool_security_test_base.py
dinghwah Mar 8, 2024
4793f3c
restore pool_security_test_base.py
dinghwah Apr 24, 2024
461297a
recommit
dinghwah Apr 21, 2023
a0fd1cb
DAOS-15396 test: Coverage Report on Master March 2024
dinghwah Mar 8, 2024
41ab9a9
retore pool_security_test_base.py
dinghwah Mar 8, 2024
e9eb3de
restore pool_security_test_base.py
dinghwah Apr 24, 2024
f01114d
Restore pool_security_test_base.py
dinghwah May 23, 2024
5a827bb
Merge branch 'master' into dinghwah/DAOS-16268-Daostest
dinghwah Sep 12, 2024
4f02db4
recommit
dinghwah Apr 21, 2023
a33aecc
DAOS-15396 test: Coverage Report on Master March 2024
dinghwah Mar 8, 2024
913555f
retore pool_security_test_base.py
dinghwah Mar 8, 2024
172dc34
restore pool_security_test_base.py
dinghwah Apr 24, 2024
70b0d67
recommit
dinghwah Apr 21, 2023
5508409
DAOS-15396 test: Coverage Report on Master March 2024
dinghwah Mar 8, 2024
6bfe729
retore pool_security_test_base.py
dinghwah Mar 8, 2024
24936c4
restore pool_security_test_base.py
dinghwah Apr 24, 2024
a2c6b30
Restore pool_security_test_base.py
dinghwah May 23, 2024
bdd6ffc
Merge branch 'master' into dinghwah/DAOS-16268-Daostest
dinghwah Sep 24, 2024
15219c3
recommit
dinghwah Apr 21, 2023
e055c89
DAOS-15396 test: Coverage Report on Master March 2024
dinghwah Mar 8, 2024
956e7b2
retore pool_security_test_base.py
dinghwah Mar 8, 2024
518f7da
restore pool_security_test_base.py
dinghwah Apr 24, 2024
f8238ba
recommit
dinghwah Apr 21, 2023
4cb01af
DAOS-15396 test: Coverage Report on Master March 2024
dinghwah Mar 8, 2024
120a0ef
retore pool_security_test_base.py
dinghwah Mar 8, 2024
cf466a1
restore pool_security_test_base.py
dinghwah Apr 24, 2024
07f4583
Restore pool_security_test_base.py
dinghwah May 23, 2024
da7f40b
Merge branch 'master' into dinghwah/DAOS-16268-Daostest
dinghwah Sep 25, 2024
0b9e553
Update daos_rebuild_*.c per Dalton's comments, also retest daos_test …
dinghwah Sep 26, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/tests/suite/daos_rebuild_common.c
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* (C) Copyright 2016-2023 Intel Corporation.
* (C) Copyright 2016-2024 Intel Corporation.
*
* SPDX-License-Identifier: BSD-2-Clause-Patent
*/
Expand Down Expand Up @@ -1210,7 +1210,7 @@ rebuild_sub_setup_common(void **state, daos_size_t pool_size, int node_nr, uint3
*/
print_message("It can not create the pool, probably due"
" to not enough ranks %d\n", rc);
return 0;
return rc;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should remove the comment above that says

		/* Let's skip for this case, since it is possible there
		 * is not enough ranks here.
		 */

}

arg = *state;
Expand Down
2 changes: 1 addition & 1 deletion src/tests/suite/daos_rebuild_ec.c
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,7 @@ rebuild_ec_setup(void **state, int number, uint32_t rf)
print_message("It can not create the pool with %d ranks"
" probably due to not enough ranks %d\n",
number, rc);
return 0;
return rc;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should remove the comment above that says

		/* Let's skip for this case, since it is possible there
		 * is not enough ranks here.
		 */

}

arg = *state;
Expand Down
4 changes: 2 additions & 2 deletions src/tests/suite/daos_rebuild_simple.c
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* (C) Copyright 2016-2023 Intel Corporation.
* (C) Copyright 2016-2024 Intel Corporation.
*
* SPDX-License-Identifier: BSD-2-Clause-Patent
*/
Expand Down Expand Up @@ -932,7 +932,7 @@ rebuild_small_pool_n4_setup(void **state)
*/
print_message("It can not create the pool with 4 ranks"
" probably due to not enough ranks %d\n", rc);
return 0;
return rc;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should remove the comment above that says

		/* Let's skip for this case, since it is possible there
		 * is not enough ranks here.
		 */

}

arg = *state;
Expand Down
Loading