-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DAOS-16268 test: daos_test/rebuild.py tests not reporting failed pool creation #15110
Open
dinghwah
wants to merge
41
commits into
master
Choose a base branch
from
dinghwah/DAOS-16268-Daostest
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 40 commits
Commits
Show all changes
41 commits
Select commit
Hold shift + click to select a range
f43ae41
recommit
dinghwah 704278b
DAOS-15396 test: Coverage Report on Master March 2024
dinghwah 5bb6091
retore pool_security_test_base.py
dinghwah 65e360b
restore pool_security_test_base.py
dinghwah 7521808
recommit
dinghwah b71da8c
DAOS-15396 test: Coverage Report on Master March 2024
dinghwah 68d36ef
retore pool_security_test_base.py
dinghwah 9fc0350
restore pool_security_test_base.py
dinghwah f6f7b4b
Restore pool_security_test_base.py
dinghwah a532b57
DAOS-16268 test: daos_test/rebuild.py tests not reporting failed pool…
dinghwah 96c8d28
recommit
dinghwah ddb417b
DAOS-15396 test: Coverage Report on Master March 2024
dinghwah 7b1826c
retore pool_security_test_base.py
dinghwah 4793f3c
restore pool_security_test_base.py
dinghwah 461297a
recommit
dinghwah a0fd1cb
DAOS-15396 test: Coverage Report on Master March 2024
dinghwah 41ab9a9
retore pool_security_test_base.py
dinghwah e9eb3de
restore pool_security_test_base.py
dinghwah f01114d
Restore pool_security_test_base.py
dinghwah 5a827bb
Merge branch 'master' into dinghwah/DAOS-16268-Daostest
dinghwah 4f02db4
recommit
dinghwah a33aecc
DAOS-15396 test: Coverage Report on Master March 2024
dinghwah 913555f
retore pool_security_test_base.py
dinghwah 172dc34
restore pool_security_test_base.py
dinghwah 70b0d67
recommit
dinghwah 5508409
DAOS-15396 test: Coverage Report on Master March 2024
dinghwah 6bfe729
retore pool_security_test_base.py
dinghwah 24936c4
restore pool_security_test_base.py
dinghwah a2c6b30
Restore pool_security_test_base.py
dinghwah bdd6ffc
Merge branch 'master' into dinghwah/DAOS-16268-Daostest
dinghwah 15219c3
recommit
dinghwah e055c89
DAOS-15396 test: Coverage Report on Master March 2024
dinghwah 956e7b2
retore pool_security_test_base.py
dinghwah 518f7da
restore pool_security_test_base.py
dinghwah f8238ba
recommit
dinghwah 4cb01af
DAOS-15396 test: Coverage Report on Master March 2024
dinghwah 120a0ef
retore pool_security_test_base.py
dinghwah cf466a1
restore pool_security_test_base.py
dinghwah 07f4583
Restore pool_security_test_base.py
dinghwah da7f40b
Merge branch 'master' into dinghwah/DAOS-16268-Daostest
dinghwah 0b9e553
Update daos_rebuild_*.c per Dalton's comments, also retest daos_test …
dinghwah File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -271,7 +271,7 @@ rebuild_ec_setup(void **state, int number, uint32_t rf) | |
print_message("It can not create the pool with %d ranks" | ||
" probably due to not enough ranks %d\n", | ||
number, rc); | ||
return 0; | ||
return rc; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We should remove the comment above that says
|
||
} | ||
|
||
arg = *state; | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
/** | ||
* (C) Copyright 2016-2023 Intel Corporation. | ||
* (C) Copyright 2016-2024 Intel Corporation. | ||
* | ||
* SPDX-License-Identifier: BSD-2-Clause-Patent | ||
*/ | ||
|
@@ -932,7 +932,7 @@ rebuild_small_pool_n4_setup(void **state) | |
*/ | ||
print_message("It can not create the pool with 4 ranks" | ||
" probably due to not enough ranks %d\n", rc); | ||
return 0; | ||
return rc; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We should remove the comment above that says
|
||
} | ||
|
||
arg = *state; | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should remove the comment above that says