Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-16268 test: daos_test/rebuild.py tests not reporting failed pool creation #15110

Open
wants to merge 41 commits into
base: master
Choose a base branch
from
Open

DAOS-16268 test: daos_test/rebuild.py tests not reporting failed pool creation #15110

wants to merge 41 commits into from

Conversation

dinghwah
Copy link
Contributor

Description: Update "return rc" to determine pass/fail instead of "return 0" in setup.

Test-tag: test_daos_dfs_unit
Allow-unstable-test: true
Doc-only: false
Required-githooks: true
Signed-off-by: Ding Ho ding-hwa.ho@intel.com

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@dinghwah
recommit
f43ae41 
Skip-fnbullseye: false
Skip-bullseye: false
Skip-python-bandit: true
Skip-nlt: true
Skip-build-leap15-rpm: true
Skip-scan-leap15-rpms: true
Allow-unstable-test: true
Doc-only: false
Test-tag: sec_basic
Required-githooks: true
Signed-off-by: Ding Ho ding-hwa.ho@intel.com
@dinghwah
DAOS-15396 test: Coverage Report on Master March 2024
704278b 
Test only, please do not merge.

Skip-fnbullseye: false
Skip-bullseye: false
Skip-python-bandit: true
Skip-build-EL9-rpm: true
Test-tag: pr daily_regression full_regression
Skip-func-hw-test-medium-md-on-ssd: false
Skip-func-hw-test-medium-verbs-provider-md-on-ssd: false
Skip-func-hw-test-medium-ucx-provider: false
Skip-func-hw-test-large-md-on-ssd: false
Allow-unstable-test: true
Doc-only: false
Required-githooks: true
Signed-off-by: Ding Ho ding-hwa.ho@intel.com

Skip-fnbullseye: false
Skip-bullseye: false
Skip-python-bandit: true
Skip-build-EL9-rpm: true
Allow-unstable-test: true
Doc-only: false
Test-nvme: auto_md_on_ssd
Test-tag: pr daily_regression full_regression
Required-githooks: true
Signed-off-by: Ding Ho ding-hwa.ho@intel.com
@dinghwah
retore pool_security_test_base.py
5bb6091 
Required-githooks: true
@dinghwah
restore pool_security_test_base.py
65e360b 
Required-githooks: true
@dinghwah
recommit
7521808 
Skip-fnbullseye: false
Skip-bullseye: false
Skip-python-bandit: true
Skip-nlt: true
Skip-build-leap15-rpm: true
Skip-scan-leap15-rpms: true
Allow-unstable-test: true
Doc-only: false
Test-tag: sec_basic
Required-githooks: true
Signed-off-by: Ding Ho ding-hwa.ho@intel.com
@dinghwah
DAOS-15396 test: Coverage Report on Master March 2024
b71da8c 
Test only, please do not merge.

Skip-fnbullseye: false
Skip-bullseye: false
Skip-python-bandit: true
Skip-build-EL9-rpm: true
Test-tag: pr daily_regression full_regression
Skip-func-hw-test-medium-md-on-ssd: false
Skip-func-hw-test-medium-verbs-provider-md-on-ssd: false
Skip-func-hw-test-medium-ucx-provider: false
Skip-func-hw-test-large-md-on-ssd: false
Allow-unstable-test: true
Doc-only: false
Required-githooks: true
Signed-off-by: Ding Ho ding-hwa.ho@intel.com

Skip-fnbullseye: false
Skip-bullseye: false
Skip-python-bandit: true
Skip-build-EL9-rpm: true
Allow-unstable-test: true
Doc-only: false
Test-nvme: auto_md_on_ssd
Test-tag: pr daily_regression full_regression
Required-githooks: true
Signed-off-by: Ding Ho ding-hwa.ho@intel.com
@dinghwah
retore pool_security_test_base.py
68d36ef 
Required-githooks: true
@dinghwah
restore pool_security_test_base.py
9fc0350 
Required-githooks: true
@dinghwah
Restore pool_security_test_base.py
f6f7b4b 
Required-githooks: true
@dinghwah
DAOS-16268 test: daos_test/rebuild.py tests not reporting failed pool…
a532b57 
… creation

Update "return rc" to determine pass/fail instead of "return 0" in setup.

Test-tag: test_daos_dfs_unit
Allow-unstable-test: true
Doc-only: false
Required-githooks: true
Signed-off-by: Ding Ho <ding-hwa.ho@intel.com>
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 10, 2024 •
edited
Loading

Ticket title is 'daos_test/rebuild.py tests not reporting failed pool creation - false pass'
Status is 'In Progress'
Labels: 'scrubbed_2.8,testp2'
https://daosio.atlassian.net/browse/DAOS-16268

@dinghwah dinghwah marked this pull request as draft September 10, 2024 02:43
@dinghwah
recommit
96c8d28 
Skip-fnbullseye: false
Skip-bullseye: false
Skip-python-bandit: true
Skip-nlt: true
Skip-build-leap15-rpm: true
Skip-scan-leap15-rpms: true
Allow-unstable-test: true
Doc-only: false
Test-tag: sec_basic
Required-githooks: true
Signed-off-by: Ding Ho ding-hwa.ho@intel.com
@dinghwah
DAOS-15396 test: Coverage Report on Master March 2024
ddb417b 
Test only, please do not merge.

Skip-fnbullseye: false
Skip-bullseye: false
Skip-python-bandit: true
Skip-build-EL9-rpm: true
Test-tag: pr daily_regression full_regression
Skip-func-hw-test-medium-md-on-ssd: false
Skip-func-hw-test-medium-verbs-provider-md-on-ssd: false
Skip-func-hw-test-medium-ucx-provider: false
Skip-func-hw-test-large-md-on-ssd: false
Allow-unstable-test: true
Doc-only: false
Required-githooks: true
Signed-off-by: Ding Ho ding-hwa.ho@intel.com

Skip-fnbullseye: false
Skip-bullseye: false
Skip-python-bandit: true
Skip-build-EL9-rpm: true
Allow-unstable-test: true
Doc-only: false
Test-nvme: auto_md_on_ssd
Test-tag: pr daily_regression full_regression
Required-githooks: true
Signed-off-by: Ding Ho ding-hwa.ho@intel.com
@dinghwah
retore pool_security_test_base.py
7b1826c 
Required-githooks: true
@dinghwah
restore pool_security_test_base.py
4793f3c 
Required-githooks: true
@dinghwah
recommit
461297a 
Skip-fnbullseye: false
Skip-bullseye: false
Skip-python-bandit: true
Skip-nlt: true
Skip-build-leap15-rpm: true
Skip-scan-leap15-rpms: true
Allow-unstable-test: true
Doc-only: false
Test-tag: sec_basic
Required-githooks: true
Signed-off-by: Ding Ho ding-hwa.ho@intel.com
@dinghwah
DAOS-15396 test: Coverage Report on Master March 2024
a0fd1cb 
Test only, please do not merge.

Skip-fnbullseye: false
Skip-bullseye: false
Skip-python-bandit: true
Skip-build-EL9-rpm: true
Test-tag: pr daily_regression full_regression
Skip-func-hw-test-medium-md-on-ssd: false
Skip-func-hw-test-medium-verbs-provider-md-on-ssd: false
Skip-func-hw-test-medium-ucx-provider: false
Skip-func-hw-test-large-md-on-ssd: false
Allow-unstable-test: true
Doc-only: false
Required-githooks: true
Signed-off-by: Ding Ho ding-hwa.ho@intel.com

Skip-fnbullseye: false
Skip-bullseye: false
Skip-python-bandit: true
Skip-build-EL9-rpm: true
Allow-unstable-test: true
Doc-only: false
Test-nvme: auto_md_on_ssd
Test-tag: pr daily_regression full_regression
Required-githooks: true
Signed-off-by: Ding Ho ding-hwa.ho@intel.com
@dinghwah
retore pool_security_test_base.py
41ab9a9 
Required-githooks: true
@dinghwah
restore pool_security_test_base.py
e9eb3de 
Required-githooks: true
@dinghwah
Restore pool_security_test_base.py
f01114d 
Required-githooks: true
@dinghwah
Merge branch 'master' into dinghwah/DAOS-16268-Daostest
5a827bb 
Test-tag: DaosCoreTestRebuild
Allow-unstable-test: true
Doc-only: false
Required-githooks: true
Signed-off-by: Ding Ho <ding-hwa.ho@intel.com>
@dinghwah
recommit
4f02db4 
Skip-fnbullseye: false
Skip-bullseye: false
Skip-python-bandit: true
Skip-nlt: true
Skip-build-leap15-rpm: true
Skip-scan-leap15-rpms: true
Allow-unstable-test: true
Doc-only: false
Test-tag: sec_basic
Required-githooks: true
Signed-off-by: Ding Ho ding-hwa.ho@intel.com
@dinghwah
DAOS-15396 test: Coverage Report on Master March 2024
a33aecc 
Test only, please do not merge.

Skip-fnbullseye: false
Skip-bullseye: false
Skip-python-bandit: true
Skip-build-EL9-rpm: true
Test-tag: pr daily_regression full_regression
Skip-func-hw-test-medium-md-on-ssd: false
Skip-func-hw-test-medium-verbs-provider-md-on-ssd: false
Skip-func-hw-test-medium-ucx-provider: false
Skip-func-hw-test-large-md-on-ssd: false
Allow-unstable-test: true
Doc-only: false
Required-githooks: true
Signed-off-by: Ding Ho ding-hwa.ho@intel.com

Skip-fnbullseye: false
Skip-bullseye: false
Skip-python-bandit: true
Skip-build-EL9-rpm: true
Allow-unstable-test: true
Doc-only: false
Test-nvme: auto_md_on_ssd
Test-tag: pr daily_regression full_regression
Required-githooks: true
Signed-off-by: Ding Ho ding-hwa.ho@intel.com
@dinghwah
retore pool_security_test_base.py
913555f 
Required-githooks: true
@dinghwah
restore pool_security_test_base.py
172dc34 
Required-githooks: true
@dinghwah
recommit
70b0d67 
Skip-fnbullseye: false
Skip-bullseye: false
Skip-python-bandit: true
Skip-nlt: true
Skip-build-leap15-rpm: true
Skip-scan-leap15-rpms: true
Allow-unstable-test: true
Doc-only: false
Test-tag: sec_basic
Required-githooks: true
Signed-off-by: Ding Ho ding-hwa.ho@intel.com
@dinghwah
DAOS-15396 test: Coverage Report on Master March 2024
5508409 
Test only, please do not merge.

Skip-fnbullseye: false
Skip-bullseye: false
Skip-python-bandit: true
Skip-build-EL9-rpm: true
Test-tag: pr daily_regression full_regression
Skip-func-hw-test-medium-md-on-ssd: false
Skip-func-hw-test-medium-verbs-provider-md-on-ssd: false
Skip-func-hw-test-medium-ucx-provider: false
Skip-func-hw-test-large-md-on-ssd: false
Allow-unstable-test: true
Doc-only: false
Required-githooks: true
Signed-off-by: Ding Ho ding-hwa.ho@intel.com

Skip-fnbullseye: false
Skip-bullseye: false
Skip-python-bandit: true
Skip-build-EL9-rpm: true
Allow-unstable-test: true
Doc-only: false
Test-nvme: auto_md_on_ssd
Test-tag: pr daily_regression full_regression
Required-githooks: true
Signed-off-by: Ding Ho ding-hwa.ho@intel.com
@dinghwah
retore pool_security_test_base.py
6bfe729 
Required-githooks: true
@dinghwah
restore pool_security_test_base.py
24936c4 
Required-githooks: true
@dinghwah
Restore pool_security_test_base.py
a2c6b30 
Required-githooks: true
@dinghwah
Merge branch 'master' into dinghwah/DAOS-16268-Daostest
bdd6ffc 
Test-tag: DaosCoreTest
Skip-func-hw-test-medium-md-on-ssd: false
Skip-func-hw-test-medium: false
Allow-unstable-test: true
Doc-only: false
Required-githooks: true
Signed-off-by: Ding Ho <ding-hwa.ho@intel.com>
@dinghwah
recommit
15219c3 
Skip-fnbullseye: false
Skip-bullseye: false
Skip-python-bandit: true
Skip-nlt: true
Skip-build-leap15-rpm: true
Skip-scan-leap15-rpms: true
Allow-unstable-test: true
Doc-only: false
Test-tag: sec_basic
Required-githooks: true
Signed-off-by: Ding Ho ding-hwa.ho@intel.com
@dinghwah
DAOS-15396 test: Coverage Report on Master March 2024
e055c89 
Test only, please do not merge.

Skip-fnbullseye: false
Skip-bullseye: false
Skip-python-bandit: true
Skip-build-EL9-rpm: true
Test-tag: pr daily_regression full_regression
Skip-func-hw-test-medium-md-on-ssd: false
Skip-func-hw-test-medium-verbs-provider-md-on-ssd: false
Skip-func-hw-test-medium-ucx-provider: false
Skip-func-hw-test-large-md-on-ssd: false
Allow-unstable-test: true
Doc-only: false
Required-githooks: true
Signed-off-by: Ding Ho ding-hwa.ho@intel.com

Skip-fnbullseye: false
Skip-bullseye: false
Skip-python-bandit: true
Skip-build-EL9-rpm: true
Allow-unstable-test: true
Doc-only: false
Test-nvme: auto_md_on_ssd
Test-tag: pr daily_regression full_regression
Required-githooks: true
Signed-off-by: Ding Ho ding-hwa.ho@intel.com
@dinghwah
retore pool_security_test_base.py
956e7b2 
Required-githooks: true
@dinghwah
restore pool_security_test_base.py
518f7da 
Required-githooks: true
@dinghwah
recommit
f8238ba 
Skip-fnbullseye: false
Skip-bullseye: false
Skip-python-bandit: true
Skip-nlt: true
Skip-build-leap15-rpm: true
Skip-scan-leap15-rpms: true
Allow-unstable-test: true
Doc-only: false
Test-tag: sec_basic
Required-githooks: true
Signed-off-by: Ding Ho ding-hwa.ho@intel.com
@dinghwah
DAOS-15396 test: Coverage Report on Master March 2024
4cb01af 
Test only, please do not merge.

Skip-fnbullseye: false
Skip-bullseye: false
Skip-python-bandit: true
Skip-build-EL9-rpm: true
Test-tag: pr daily_regression full_regression
Skip-func-hw-test-medium-md-on-ssd: false
Skip-func-hw-test-medium-verbs-provider-md-on-ssd: false
Skip-func-hw-test-medium-ucx-provider: false
Skip-func-hw-test-large-md-on-ssd: false
Allow-unstable-test: true
Doc-only: false
Required-githooks: true
Signed-off-by: Ding Ho ding-hwa.ho@intel.com

Skip-fnbullseye: false
Skip-bullseye: false
Skip-python-bandit: true
Skip-build-EL9-rpm: true
Allow-unstable-test: true
Doc-only: false
Test-nvme: auto_md_on_ssd
Test-tag: pr daily_regression full_regression
Required-githooks: true
Signed-off-by: Ding Ho ding-hwa.ho@intel.com
@dinghwah
retore pool_security_test_base.py
120a0ef 
Required-githooks: true
@dinghwah
restore pool_security_test_base.py
cf466a1 
Required-githooks: true
@dinghwah
Restore pool_security_test_base.py
07f4583 
Required-githooks: true
@dinghwah
Merge branch 'master' into dinghwah/DAOS-16268-Daostest
da7f40b 
Test-tag: daos_test
Skip-func-hw-test-medium-md-on-ssd: false
Skip-func-hw-test-medium: false
Skip-func-hw-test-large-md-on-ssd: false
Skip-func-hw-test-large: false
Allow-unstable-test: true
Doc-only: false
Required-githooks: true
Signed-off-by: Ding Ho <ding-hwa.ho@intel.com>
@daltonbohning
Copy link
Contributor

Curious, why so many unrelated commits here?
https://github.com/daos-stack/daos/pull/15110/commits

daltonbohning
daltonbohning reviewed Sep 26, 2024
View reviewed changes
src/tests/suite/daos_rebuild_common.c
@@ -1210,7 +1210,7 @@ rebuild_sub_setup_common(void **state, daos_size_t pool_size, int node_nr, uint3
*/
print_message("It can not create the pool, probably due"
" to not enough ranks %d\n", rc);
return 0;
return rc;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should remove the comment above that says

		/* Let's skip for this case, since it is possible there
		 * is not enough ranks here.
		 */

src/tests/suite/daos_rebuild_ec.c
@@ -271,7 +271,7 @@ rebuild_ec_setup(void **state, int number, uint32_t rf)
print_message("It can not create the pool with %d ranks"
" probably due to not enough ranks %d\n",
number, rc);
return 0;
return rc;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should remove the comment above that says

		/* Let's skip for this case, since it is possible there
		 * is not enough ranks here.
		 */

src/tests/suite/daos_rebuild_simple.c
@@ -932,7 +932,7 @@ rebuild_small_pool_n4_setup(void **state)
*/
print_message("It can not create the pool with 4 ranks"
" probably due to not enough ranks %d\n", rc);
return 0;
return rc;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should remove the comment above that says

		/* Let's skip for this case, since it is possible there
		 * is not enough ranks here.
		 */

@dinghwah
Update daos_rebuild_*.c per Dalton's comments, also retest daos_test …
0b9e553 
…for stability.

Test-tag: daos_test
Skip-func-hw-test-medium-md-on-ssd: false
Skip-func-hw-test-medium: false
Skip-func-hw-test-large-md-on-ssd: false
Skip-func-hw-test-large: false
Allow-unstable-test: true
Doc-only: false
Required-githooks: true
Signed-off-by: Ding Ho <ding-hwa.ho@intel.com>
@dinghwah dinghwah marked this pull request as ready for review September 27, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kccain kccain Awaiting requested review from kccain

@phender phender Awaiting requested review from phender

@daltonbohning daltonbohning Awaiting requested review from daltonbohning

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dinghwah @daltonbohning