Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-15805 control: Adjust SPDK config entry order to avoid hotplug r… #14522

Merged

Conversation

tanabarr
Copy link
Contributor

@tanabarr tanabarr commented Jun 6, 2024

…ace (#14480)

Ensure hotplug directives in SPDK JSON configuration appear after any device attach entries to avoid enumeration race seen with multiple VMD domains and described in spdk/spdk#3370.

Features: control
Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

…ace (#14480)

Ensure hotplug directives in SPDK JSON configuration appear after any
device attach entries to avoid enumeration race seen with multiple
VMD domains and described in spdk/spdk#3370.

Features: control
Required-githooks: true

Signed-off-by: Tom Nabarro <tom.nabarro@intel.com>
@tanabarr tanabarr requested review from a team as code owners June 6, 2024 16:26
@tanabarr tanabarr self-assigned this Jun 6, 2024
@tanabarr tanabarr requested review from kjacque and knard38 June 6, 2024 16:27
@tanabarr tanabarr added control-plane work on the management infrastructure of the DAOS Control Plane vmd Relates to Intel VMD capability dependencies Pull requests that update a dependency file go Pull requests that update Go code release-2.6 labels Jun 6, 2024
Copy link

github-actions bot commented Jun 6, 2024

Ticket title is 'Engine doesn't start with two VMD controller addresses in the same engine with hotplug enabled'
Status is 'Awaiting backport'
Labels: 'Go,SPDK,VMD,hotplug,scrubbed_2.8,triaged'
Job should run at elevated priority (1)
https://daosio.atlassian.net/browse/DAOS-15805

@github-actions github-actions bot added the priority Ticket has high priority (automatically managed) label Jun 6, 2024
@tanabarr tanabarr requested a review from a team June 11, 2024 09:11
@tanabarr tanabarr added the clean-cherry-pick Cherry-pick from another branch that did not require additional edits label Jun 11, 2024
@daltonbohning daltonbohning merged commit 5ee1f27 into release/2.6 Jun 11, 2024
58 checks passed
@daltonbohning daltonbohning deleted the tanabarr/control-vmd-hotplug-multidomain-fix-rel2_6 branch June 11, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clean-cherry-pick Cherry-pick from another branch that did not require additional edits control-plane work on the management infrastructure of the DAOS Control Plane dependencies Pull requests that update a dependency file go Pull requests that update Go code priority Ticket has high priority (automatically managed) release-2.6 vmd Relates to Intel VMD capability
Development

Successfully merging this pull request may close these issues.

4 participants