Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-15805 control: Adjust SPDK config entry order to avoid hotplug race #14480

Merged
merged 1 commit into from
Jun 5, 2024
Merged

DAOS-15805 control: Adjust SPDK config entry order to avoid hotplug race #14480

merged 1 commit into from
Jun 5, 2024

Conversation

tanabarr
Copy link
Contributor

@tanabarr tanabarr commented May 30, 2024 •
edited
Loading

Ensure hotplug directives in SPDK JSON configuration appear after any
device attach entries to avoid enumeration race seen with multiple
VMD domains and described in spdk/spdk#3370.

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@tanabarr tanabarr requested review from a team as code owners May 30, 2024 14:31
@tanabarr tanabarr self-assigned this May 30, 2024
@github-actions GitHub Actions
Copy link

Ticket title is 'Engine doesn't start with two VMD controller addresses in the same engine with hotplug enabled'
Status is 'Awaiting Verification'
Labels: 'hotplug,triaged'
https://daosio.atlassian.net/browse/DAOS-15805

@tanabarr
DAOS-15805 control: Adjust SPDK config entry order to avoid hotplug race
36c7dbe 
Required-githooks: true

Signed-off-by: Tom Nabarro <tom.nabarro@intel.com>
@tanabarr tanabarr added control-plane work on the management infrastructure of the DAOS Control Plane dependencies Pull requests that update a dependency file vmd Relates to Intel VMD capability go Pull requests that update Go code labels May 30, 2024
@tanabarr
Copy link
Contributor Author

tanabarr commented Jun 3, 2024

GHA leap15 build getting cancelled when run:
https://github.com/daos-stack/daos/actions/runs/9304353797?pr=14480

@tanabarr tanabarr requested a review from a team June 4, 2024 10:20
@tanabarr
Copy link
Contributor Author

tanabarr commented Jun 5, 2024

@daos-stack/daos-gatekeeper can this please be considered when landing opens?

@mjmac mjmac merged commit 85d3521 into master Jun 5, 2024
53 checks passed
@mjmac mjmac deleted the tanabarr/control-vmd-hotplug-multidomain-fix branch June 5, 2024 12:42
tanabarr added a commit that referenced this pull request Jun 6, 2024
@tanabarr
DAOS-15805 control: Adjust SPDK config entry order to avoid hotplug r…
a58d17b 
…ace (#14480)

Ensure hotplug directives in SPDK JSON configuration appear after any
device attach entries to avoid enumeration race seen with multiple
VMD domains and described in spdk/spdk#3370.

Signed-off-by: Tom Nabarro <tom.nabarro@intel.com>
tanabarr added a commit that referenced this pull request Jun 6, 2024
@tanabarr
DAOS-15805 control: Adjust SPDK config entry order to avoid hotplug r…
a4747a6 
…ace (#14480)

Ensure hotplug directives in SPDK JSON configuration appear after any
device attach entries to avoid enumeration race seen with multiple
VMD domains and described in spdk/spdk#3370.

Features: control
Required-githooks: true

Signed-off-by: Tom Nabarro <tom.nabarro@intel.com>
@tanabarr tanabarr mentioned this pull request Jun 6, 2024
Merged
18 tasks
daltonbohning pushed a commit that referenced this pull request Jun 11, 2024
@tanabarr
DAOS-15805 control: Adjust SPDK config entry order to avoid hotplug r…
5ee1f27 
…ace (#14480) (#14522)

Ensure hotplug directives in SPDK JSON configuration appear after any
device attach entries to avoid enumeration race seen with multiple
VMD domains and described in spdk/spdk#3370.

Signed-off-by: Tom Nabarro <tom.nabarro@intel.com>
@mjmac mjmac mentioned this pull request Nov 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knard38 knard38 knard38 approved these changes

@kjacque kjacque kjacque approved these changes

@NiuYawei NiuYawei Awaiting requested review from NiuYawei

@mjmac mjmac Awaiting requested review from mjmac

Assignees

@tanabarr tanabarr

Labels
control-plane work on the management infrastructure of the DAOS Control Plane dependencies Pull requests that update a dependency file go Pull requests that update Go code vmd Relates to Intel VMD capability
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tanabarr @kjacque @knard38 @mjmac