DAOS-14248 engine: strengthen signals handling

src/engine/init.c

@@ -1191,6 +1191,7 @@ main(int argc, char **argv)
 	sigdelset(&set, SIGFPE);
 	sigdelset(&set, SIGBUS);
 	sigdelset(&set, SIGSEGV);
+	sigdelset(&set, SIGTRAP);
 	/** also allow abort()/assert() to trigger */
 	sigdelset(&set, SIGABRT);
 
@@ -1281,6 +1282,8 @@ main(int argc, char **argv)
 		if (sig == SIGUSR1) {
 			D_INFO("got SIGUSR1, dumping Argobots infos and ULTs stacks\n");
 			dss_dump_ABT_state(abt_infos);
+			/* re-add SIGUSR1 to set */
+			sigaddset(&set, SIGUSR1);
 			continue;
 		}
 
@@ -1292,6 +1295,8 @@ main(int argc, char **argv)
 			ABT_info_trigger_print_all_thread_stacks(abt_infos,
 								 10.0, NULL,
 								 NULL);
+			/* re-add SIGUSR2 to set */
+			sigaddset(&set, SIGUSR2);
 			continue;
 		}
 

src/gurt/signals.c

@@ -91,7 +91,14 @@ print_backtrace(int signo, siginfo_t *info, void *p)
 		PRINT_ERROR("No useful backtrace available");
 	}
 
-	/* re-register old handler */
+	/* re-register old handler
+	 *
+	 * XXX we may choose to forget about old handler and simply register
+	 * signal again as SIG_DFL and raise it for corefile creation
+	 *
+	 * XXX will old handler get accurate/original siginfo_t/ucontext_t ?
+	 * should we instead call it with the same params we got ?
+	 */
 	rc = sigaction(signo, &old_handlers[signo], NULL);
 	if (rc != 0) {
 		D_ERROR("sigaction() failure registering new and reading old %d signal handler",
@@ -102,17 +109,8 @@ print_backtrace(int signo, siginfo_t *info, void *p)
 		exit(EXIT_FAILURE);
 	}
 
-	/* XXX we may choose to forget about old handler and simply register
-	 * signal again as SIG_DFL and raise it for corefile creation
-	 */
-	if (old_handlers[signo].sa_sigaction != NULL || old_handlers[signo].sa_handler != SIG_IGN) {
-		/* XXX will old handler get accurate siginfo_t/ucontext_t ?
-		 * we may prefer to call it with the same params we got ?
-		 */
-		raise(signo);
-	}
-
-	memset(&old_handlers[signo], 0, sizeof(struct sigaction));
+	/* raise signal again for either old handler or system default action */
+	raise(signo);
 }
 
 static bool register_handler = false;
@@ -142,6 +140,7 @@ d_signal_register()
 	daos_register_sighand(SIGBUS, print_backtrace);
 	daos_register_sighand(SIGSEGV, print_backtrace);
 	daos_register_sighand(SIGABRT, print_backtrace);
+	daos_register_sighand(SIGTRAP, print_backtrace);
 
 	registered = true;
 }