Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-14248 engine: strengthen signals handling #13031

Merged
merged 5 commits into from
Sep 19, 2024
Merged

DAOS-14248 engine: strengthen signals handling #13031

merged 5 commits into from
Sep 19, 2024

Conversation

bfaccini
Copy link
Contributor

@bfaccini bfaccini commented Sep 11, 2023 •
edited
Loading

Re-raise signal in all cases.
Also catch SIGTRAP.
Re-add USR1/USR2 signals to waiting set when triggered.

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate watchers.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@bfaccini
DAOS-14248 engine: strengthen signals handling
1206c4c 
Re-register DAOS handler in case original handler returns.

Re-add USR1/USR2 signals to waiting set when triggered.

Required-githooks: true

Signed-off-by: Bruno Faccini <bruno.faccini@intel.com>
@github-actions
Copy link

Bug-tracker data:
Ticket title is 'dump of engine's ULTs stacks only works one time'
Status is 'In Review'
https://daosio.atlassian.net/browse/DAOS-14248

daosbuild1
daosbuild1 reviewed Sep 11, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13031/1/execution/node/1119/log

@bfaccini bfaccini self-assigned this Sep 12, 2023
@bfaccini
DAOS-14248 engine: do not re-register handler
bc5d9e9 
My previous change/commit was wrongly re-register
DAOS signal handler.

Also catch SIGTRAP.

Required-githooks: true

Signed-off-by: Bruno Faccini <bruno.faccini@intel.com>
daosbuild1
daosbuild1 reviewed Sep 14, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium Verbs Provider completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-13031/2/testReport/

@bfaccini
Copy link
Contributor Author

Only failure in CI is :

Test Hardware / Functional Hardware Medium Verbs Provider / UPGRADE2: upgrade with dfs - FTEST_daos_test.DAOS_upgrade
Stacktrace
0x16 != 0
src/tests/suite/daos_upgrade.c:255: error: Failure!

looks definitelly unrelated and already being addressed by DAOS-14188 JIRA ticket, where fix/PR-12883 still has not landed.

@knard38 knard38 mentioned this pull request May 15, 2024
Closed
18 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented May 17, 2024 •
edited
Loading

Ticket title is 'dump of engine's ULTs stacks only works one time'
Status is 'In Review'
https://daosio.atlassian.net/browse/DAOS-14248

@knard38 knard38 self-assigned this May 17, 2024
@knard38
Copy link
Contributor

knard38 commented May 27, 2024

@johannlombardi and @ashleypittman , please could you tell me if this PR is OK for you ?

@knard38 knard38 marked this pull request as ready for review May 27, 2024 06:57
@knard38 knard38 requested a review from a team as a code owner May 27, 2024 06:57
@knard38
Copy link
Contributor

knard38 commented Jun 10, 2024

@johannlombardi and @ashleypittman , please could you tell me if this PR is OK for you ?

@knard38
Copy link
Contributor

knard38 commented Jun 24, 2024

@ashleypittman , please could you tell me if this PR is OK for you ?

1 similar comment
@knard38
Copy link
Contributor

knard38 commented Jul 26, 2024

@ashleypittman , please could you tell me if this PR is OK for you ?

@knard38 knard38 requested a review from wangshilong September 10, 2024 09:17
@knard38 knard38 requested a review from a team September 13, 2024 07:12
@daltonbohning
Copy link
Contributor

This PR is 4 months stale and needs to be updated and testing reran.

@daltonbohning daltonbohning removed the request for review from a team September 16, 2024 15:46
@knard38
Copy link
Contributor

knard38 commented Sep 18, 2024 •
edited
Loading

This PR is 4 months stale and needs to be updated and testing reran.

Merged and send to CI.
Sadly, I will not be able to investigate on eventual CI errors as I have still not received my new company laptop.
Hopefully everything will go smoothly ;-)

@knard38 knard38 requested a review from a team September 19, 2024 07:51
@knard38
Copy link
Contributor

knard38 commented Sep 19, 2024 •
edited
Loading

This PR is 4 months stale and needs to be updated and testing reran.

Still good... my new company laptop should not be needed for this PR :-)

@daltonbohning daltonbohning merged commit a9bcfe6 into master Sep 19, 2024
55 checks passed
@daltonbohning daltonbohning deleted the bfaccini/DAOS-14248 branch September 19, 2024 13:34
@mjmac mjmac mentioned this pull request Nov 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daosbuild1 daosbuild1 daosbuild1 left review comments

@wangshilong wangshilong wangshilong approved these changes

@johannlombardi johannlombardi johannlombardi approved these changes

@ashleypittman ashleypittman Awaiting requested review from ashleypittman

Assignees

@bfaccini bfaccini

@knard38 knard38

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@bfaccini @daosbuild1 @knard38 @daltonbohning @johannlombardi @wangshilong @kanard38