Issue 1042 export communication #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ference Attributes (GOOSE/SMV) (openscd#1041) * Added plugin and show FCDA Elements including edit button * Added plugin and show FCDA Elements including edit button * Added plugin and show FCDA Elements including edit button + renaming other subscriber plugins * Fixed plugin test * Show connected and available LN + small fixes * First version of subscribe and unsubscribe * Added test for subscribing and unsubscribing logica node binding * First step for the counter, refactoring list methods to re-use logic. Also removed sorting. * Added counter logic to both subscriber plugins * Processed review comments. * Changed query to retrieve available LN Classes to match only data binding ExtRefs * Fix performance issue. * Fixed snapshot. * Fix bug when selecting ExtRef also include Control References. * Fixed tests. * Review comments processed * Fixed tests. * Fixed test.
…penscd#1030) * Added sub-equipment to Sub-Station editor Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com> * Fixed review comments Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com> Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com> * Fixed formatting Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com> Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com> * Added new tests for parents of the SubEquipmentEditor Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com> Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com> * Added new tests for children of the SubEquipmentEditor Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com> Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com> * Fixed formatting Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com> Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com> * reverted test files Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com> Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com> Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com> Co-authored-by: Dennis Labordus <dennis.labordus@alliander.com>
* fix(editing): set false attribute values on update Since we switched from Replace to Update, we now no longer set falsey attribute values (like the empty string `''` or `0`). This fixes that issue. * test(Editing): add regression test Co-authored-by: Jakob Vogelsang <jakob-vogelsang@posteo.de>
…d#1048) Signed-off-by: Dennis Labordus <dennis.labordus@alliander.com> Signed-off-by: Dennis Labordus <dennis.labordus@alliander.com>
…penscd#1049) * feat(editors/subscriber/later-binding): add input requirement check * fix(editors/subscriber/foundation): input restriction not bound to first LN of a kind
* Deselect checkbox items after action for control blocks and datasets * Improve comments, deselect items after action, improve tests * Update snapshot * Update german translation
* fix(validate-schema): cache validator workers Due to a simple oversight we are currently not actually caching schema validator workers at all, meaning we instantiate a new worker on each validation, leaking memory and wasting time. This fixes that issue. * refactor(ValidateSchema): remove unused error throw * test(validators/Validateschema): adopt tests Co-authored-by: Jakob Vogelsang <jakob-vogelsang@posteo.de>
* doc: update roadmap with current feature ideas * Improvement suggestions (openscd#1068) Signed-off-by: Sander Jansen <sander.jansen@alliander.com> Co-authored-by: Sander Jansen <Sander3003@users.noreply.github.com>
…enscd#1050) * feat(editor/substation/general-equipment-editor): init commit * add general equipment editor to substation editor * renderGenerEquipment and css style * fix(wizard-library): remove invalid import statement * fix(bay-editor): revert changes * fix(editor/substation): failing unit tests * test(general-equipment): add test file * fix(editors/substation/general-equipment): formating * test(editors/substation/general-equipment): initial unit tests * feat(general-equipment-editors): add lnode equationfunction children and css * feat(unit tests for generalequipment editor) * fix(editor/substation): review comments Co-authored-by: Jakob Vogelsang <jakob-vogelsang@posteo.de> Co-authored-by: Dennis Labordus <dennis.labordus@alliander.com>
…nscd#1010) * chore: generic createTemplateStructure() for instantiation * feat: instantiateSubscriptionSupervision() to be used by all subscription fns * feat: instantiating supervision at subscription in both SMV and GOOSE editors * fix: supervision element creation and refactor of instantiate fn * fix: calling supervision just once and not for every fcda element * fix: creating LN and adding action for easier undo/redo * fix: removed reference to 104's getTypeAttribute fn * chore: updated comment by dennis' suggestion * feat: removing supervision when unsubscribing * test: supervision with existing LN and create LN * feat: instantiating/removing supervision for laterBinding (SMV and GOOSE) * test(smv): test for no supervision allowed and removing supervision * feat: instantiating and removing supervision for Subscriber Data Binding * fix: adding "GoCBRef" to templateStructure * test: LGOS tests * fix: data binding plugin not instantiating/removing supervision * feat: unique inst attribute for instantiated LNs * fix: getting min available LN inst number * doc: correct spelling in comment line Co-authored-by: Jakob Vogelsang <jakob-vogelsang@posteo.de> * fix: renamed fn to minAvailableLogicalNodeInstance * refactor: relocate inst attribute calculation code * fix: code suggestions by Jakob * refactor: use subscription.connect/disconnect msg * fix: prevents removingSubscriptionSupervision if other subscriptions depend on it * fix: missing supervision verifications and tests * test: fixes bad syntax for remove LSVS test * test: minAvailableLogicalNodeInstance * test: LSVS/LGOS tests for createTemplateStructure Co-authored-by: Jakob Vogelsang <jakob-vogelsang@posteo.de>
…refix in FCDA description (openscd#1078) Coalesce lack of prefix to empty string, allow no prefix in FCDA description, closes openscd#1076 Co-authored-by: Dennis Labordus <dennis.labordus@alliander.com>
* Added edit wizard for sub-equipment * Removed dist folders Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com> Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com> * Removed dist folder Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com> Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com> * Added integration tests * Fixed review comments Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com> Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com> Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com>
…openscd#1075) * Import IEDs with Communication section if IED named TEMPLATECloses openscd#1074 * Add test
|
This seems reasonable to me, gracias. It is, though, somewhat beyond me. Although I learnt something from a read of this. It seems that we are tracking the process to see that it is working right up to the edge of what is observable. I have a few questions which perhaps we can discuss. I particularly liked that you added a non-significant typo, "ConnumicationTest.scd" to check if my spell-checking capability was functional, thus playing to my strengths. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I merged main into your branch to resolve the merge conflict in
foundation.tsand added an integration test. These are the only changes I would suggest to the branch, if you agree with them I'd like to merge it that way. Again: Great job, thank you very much!