Run test suite using ifort on github runners #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and run in parallel on github actions
This streamlines branch protection
amend: improve comment
because labels cannot be modified without token/permissions
to add the job name into git's branch protection history
This reverts commit e87698a.
only run intel installation for system==ifort
except for benchmarks, which need consistent performance (so they won't run on forks)
"intel" was used instead of "ifort", resulting in: make: WARNING: value of SYSTEM = intel not recognised...
|
might be worth squashing the commit message on this one :) |
conradtchan
added a commit
that referenced
this pull request
Mar 1, 2022
#228 added a summary step to the build checks. This always runs, even if the build checks are skipped (scheduled builds on forks). Because no builds have passed, this returns a false fail. This change causes the workflow to only run the summary step if it is not triggered by a schedule. This will have no effect on scheduled runs on the main repo because the summary step is not used there - it is only used as a branchy protection requirement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR:
other
Description:
Intel compilers can be installed onto github runners for free, so:
Resolves Actions: Use Intel OneAPI compiler to avoid needing custom runners #227
Testing:
Full test suite
Did you run the bots? no - not required