Skip to content

Commit

Permalink
skip the gather_results step for builds if scheduled action (#248)
Browse files Browse the repository at this point in the history
#228 added a summary step to the build checks. This always runs, even if the build checks are skipped (scheduled builds on forks). Because no builds have passed, this returns a false fail.

This change causes the workflow to only run the summary step if it is not triggered by a schedule. This will have no effect on scheduled runs on the main repo because the summary step is not used there - it is only used as a branchy protection requirement.
  • Loading branch information
conradtchan committed Mar 1, 2022
1 parent 773a6bf commit fade9a7
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ jobs:
# Gather results into a dummy job that will fail if the previous job fails
gather_results:
if: always()
if: ${{ always() && github.event_name != 'schedule' }}
needs:
- build

Expand Down

0 comments on commit fade9a7

Please sign in to comment.