Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add missed tests in #2136 #2137

Merged
merged 4 commits into from
Aug 13, 2024
Merged

Conversation

omBratteng
Copy link
Member

@omBratteng omBratteng commented Aug 13, 2024

As requested @capJavert, test for #2136

auto-merge enabled 😈

@omBratteng omBratteng requested review from capJavert and a team as code owners August 13, 2024 13:56
@omBratteng omBratteng enabled auto-merge (squash) August 13, 2024 13:57
Comment on lines +1346 to +1347
expect(updatedPost.flags.vordr).toEqual(false);
expect(updatedPost.banned).toEqual(false);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add expect to make sure if post had some other flags they did not get overwritten.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added extra test, does that work?

@omBratteng omBratteng merged commit f2a6fa8 into main Aug 13, 2024
8 checks passed
@omBratteng omBratteng deleted the AS-483-fix-worker-flags-test branch August 13, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants