Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set correct vordr flags on worker too #2136

Merged
merged 1 commit into from
Aug 13, 2024
Merged

fix: set correct vordr flags on worker too #2136

merged 1 commit into from
Aug 13, 2024

Conversation

omBratteng
Copy link
Member

Realised I forgot to add the other flags on scout picks

@omBratteng omBratteng requested a review from idoshamun August 13, 2024 13:28
@omBratteng omBratteng requested review from capJavert and a team as code owners August 13, 2024 13:28
@omBratteng omBratteng enabled auto-merge (squash) August 13, 2024 13:30
capJavert
capJavert approved these changes Aug 13, 2024
View reviewed changes
Copy link
Contributor

@capJavert capJavert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you can add tests 🙏

@omBratteng omBratteng merged commit cda0608 into main Aug 13, 2024
8 checks passed
@omBratteng omBratteng deleted the AS-483-fix-worker-flags branch August 13, 2024 13:34
omBratteng added a commit that referenced this pull request Aug 13, 2024
@omBratteng
test: add missed tests in #2136
0588e2a
@omBratteng omBratteng mentioned this pull request Aug 13, 2024
Merged
omBratteng added a commit that referenced this pull request Aug 13, 2024
@omBratteng
test: add missed tests in #2136 (#2137)
f2a6fa8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idoshamun idoshamun idoshamun approved these changes

@capJavert capJavert capJavert approved these changes

@rebelchris rebelchris Awaiting requested review from rebelchris rebelchris is a code owner automatically assigned from dailydotdev/web-team

@ilasw ilasw Awaiting requested review from ilasw ilasw is a code owner automatically assigned from dailydotdev/web-team

@sshanzel sshanzel Awaiting requested review from sshanzel sshanzel is a code owner automatically assigned from dailydotdev/web-team

@nensidosari nensidosari Awaiting requested review from nensidosari nensidosari is a code owner automatically assigned from dailydotdev/web-team

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@omBratteng @idoshamun @capJavert