Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove language selection from registration #4157

Merged
merged 2 commits into from
Feb 6, 2025
Merged

feat: remove language selection from registration #4157

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c1f71ed
feat: remove language selection from registration
AmarTrebinjac Feb 6, 2025
012f833
Merge branch 'main' into MI-781
AmarTrebinjac Feb 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions packages/shared/src/components/auth/RegistrationForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ import ConditionalWrapper from '../ConditionalWrapper';
import AuthContainer from './AuthContainer';
import { onValidateHandles } from '../../hooks/useProfileForm';
import ExperienceLevelDropdown from '../profile/ExperienceLevelDropdown';
import { LanguageDropdown } from '../profile/LanguageDropdown';
import Alert, { AlertType } from '../widgets/Alert';
import { isDevelopment } from '../../lib/constants';

Expand Down Expand Up @@ -296,10 +295,6 @@ const RegistrationForm = ({
}
saveHintSpace
/>
<LanguageDropdown
className={{ container: 'w-full' }}
name="traits.language"
/>
<span className="border-b border-border-subtlest-tertiary pb-4 text-text-secondary typo-subhead">
Your email will be used to send you product and community updates
</span>
Expand Down
2 changes: 0 additions & 2 deletions packages/shared/src/components/auth/SocialRegistrationForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ import ConditionalWrapper from '../ConditionalWrapper';
import type { SignBackProvider } from '../../hooks/auth/useSignBack';
import { useSignBack } from '../../hooks/auth/useSignBack';
import ExperienceLevelDropdown from '../profile/ExperienceLevelDropdown';
import { LanguageDropdown } from '../profile/LanguageDropdown';

export interface SocialRegistrationFormProps extends AuthFormProps {
className?: string;
Expand Down Expand Up @@ -258,7 +257,6 @@ export const SocialRegistrationForm = ({
hint={experienceLevelHint}
saveHintSpace
/>
<LanguageDropdown className={{ container: 'w-full' }} name="language" />
<span className="border-b border-border-subtlest-tertiary pb-4 text-text-secondary typo-subhead">
Your email will be used to send you product and community updates
</span>
Expand Down