Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove language selection from registration #4157

Merged
merged 2 commits into from
Feb 6, 2025
Merged

feat: remove language selection from registration #4157

merged 2 commits into from
Feb 6, 2025

Conversation

AmarTrebinjac
Copy link
Contributor

@AmarTrebinjac AmarTrebinjac commented Feb 6, 2025 •
edited
Loading

Changes

Remove language option during registration due to user confusion over posts being translated.

Events

Did you introduce any new tracking events?

Experiment

Did you introduce any new experiments?

Manual Testing

Caution

Please make sure existing components are not breaking/affected by this PR

Preview domain

https://mi-781.preview.app.daily.dev

@vercel Vercel
Copy link

vercel bot commented Feb 6, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
daily-webapp ✅ Ready (Inspect) Visit Preview Feb 6, 2025 9:07am
1 Skipped Deployment
Name Status Preview Updated (UTC)
storybook ⬜️ Ignored (Inspect) Feb 6, 2025 9:07am

@AmarTrebinjac AmarTrebinjac marked this pull request as ready for review February 6, 2025 09:05
@AmarTrebinjac AmarTrebinjac requested a review from a team as a code owner February 6, 2025 09:05
sshanzel
sshanzel approved these changes Feb 6, 2025
View reviewed changes
Copy link
Member

@sshanzel sshanzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kindly verify from the preview that auth still works or whether we need to send a default value behind the scenes.

rebelchris
rebelchris approved these changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@rebelchris rebelchris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like Lee said, can't recall if we had this mandatory on heimdall side and can't test on preview due to cloudflare.

Critical flow testing is key here.

@AmarTrebinjac
Copy link
Contributor Author

Like Lee said, can't recall if we had this mandatory on heimdall side and can't test on preview due to cloudflare.

Critical flow testing is key here.

@rebelchris I will do a merge and test

@AmarTrebinjac AmarTrebinjac merged commit 5c9f827 into main Feb 6, 2025
11 checks passed
@AmarTrebinjac AmarTrebinjac deleted the MI-781 branch February 6, 2025 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rebelchris rebelchris rebelchris approved these changes

@sshanzel sshanzel sshanzel approved these changes

@omBratteng omBratteng Awaiting requested review from omBratteng omBratteng is a code owner automatically assigned from dailydotdev/web-team

@ilasw ilasw Awaiting requested review from ilasw ilasw is a code owner automatically assigned from dailydotdev/web-team

@capJavert capJavert Awaiting requested review from capJavert capJavert is a code owner automatically assigned from dailydotdev/web-team

@nensidosari nensidosari Awaiting requested review from nensidosari nensidosari is a code owner automatically assigned from dailydotdev/web-team

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AmarTrebinjac @rebelchris @sshanzel