Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjust discussed feed styles to match new mobile UX #2894

Merged
merged 7 commits into from
Apr 2, 2024
Merged

fix: adjust discussed feed styles to match new mobile UX #2894

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
eb14676
fix: adjust discussed feed styles to match new mobile UX
DragosIorgulescu Apr 1, 2024
f030104
Merge branch 'main' into MI-252-discussed-comments-feed-layout
sshanzel Apr 1, 2024
74121d8
Merge branch 'main' into MI-252-discussed-comments-feed-layout
DragosIorgulescu Apr 2, 2024
acbb3ac
fix: update font size on sidebar nav buttons
DragosIorgulescu Apr 2, 2024
6ec0a78
Merge branch 'main' into MI-252-discussed-comments-feed-layout
DragosIorgulescu Apr 2, 2024
44fbb39
fix: use `typo-caption1` for nav items text
DragosIorgulescu Apr 2, 2024
991b311
Merge branch 'main' into MI-252-discussed-comments-feed-layout
DragosIorgulescu Apr 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions packages/shared/src/components/CommentFeed.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,10 +103,7 @@ export default function CommentFeed<T>({
isFetchingNextPage={queryResult.isFetchingNextPage}
canFetchMore={checkFetchMore(queryResult)}
fetchNextPage={queryResult.fetchNextPage}
className={classNames(
'w-full',
isNewMobileLayout && isMainFeed && 'px-4',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What should this look like in control values? Can you also attach screenshot of the old UI? Just to make sure everything still looks normal.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure thing, added previous of the previous UI as well

)}
className="w-full"
>
{queryResult.data.pages.flatMap((page) =>
page.page.edges.map(({ node }, index) => (
Expand Down
2 changes: 1 addition & 1 deletion packages/shared/src/components/MainFeedLayout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ const getQueryBasedOnLogin = (
const DEFAULT_ALGORITHM_KEY = 'feed:algorithm';

const commentClassName = {
container: 'rounded-none border-0 border-b border-x',
container: 'rounded-none border-0 border-b tablet:border-x',
commentBox: {
container: 'relative border-0 rounded-none',
},
Expand Down
2 changes: 1 addition & 1 deletion packages/shared/src/components/sidebar/Sidebar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ export default function Sidebar({
variant: ButtonVariant.Tertiary,
size: ButtonSize.Large,
className:
'w-full !bg-transparent active:bg-transparent aria-pressed:bg-transparent',
'w-full !bg-transparent active:bg-transparent aria-pressed:bg-transparent typo-caption1',
};

return (
Expand Down