Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: adjust discussed feed styles to match new mobile UX #2894

Merged
merged 7 commits into from
Apr 2, 2024
Merged

fix: adjust discussed feed styles to match new mobile UX #2894

merged 7 commits into from
Apr 2, 2024

Conversation

DragosIorgulescu
Copy link
Contributor

@DragosIorgulescu DragosIorgulescu commented Apr 1, 2024 •
edited
Loading

Changes

New UI

Screenshot 2024-04-01 at 14 15 40

Previous UI

Screenshot 2024-04-02 at 12 24 32

New UI

Screenshot 2024-04-01 at 14 14 12

Previous UI

Screenshot 2024-04-02 at 12 24 53

Events

N / A

Manual Testing

On those affected packages:

  • Have you done sanity checks in the webapp?
  • Have you done sanity checks in the extension?
  • Does this not break anything in companion?

Did you test the modified components media queries?

  • MobileL (420px)
  • Tablet (656px)
  • Laptop (1020px)

Did you test on actual mobile devices?

  • iOS (Chrome and Safari)
  • Android

MI-252

@DragosIorgulescu DragosIorgulescu self-assigned this Apr 1, 2024
@DragosIorgulescu DragosIorgulescu requested a review from a team as a code owner April 1, 2024 10:57
@vercel Vercel
Copy link

vercel bot commented Apr 1, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
daily-webapp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 2, 2024 10:38am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
storybook ⬜️ Ignored (Inspect) Apr 2, 2024 10:38am

@DragosIorgulescu DragosIorgulescu force-pushed the MI-252-discussed-comments-feed-layout branch from 65b4070 to f58b623 Compare April 1, 2024 11:01
@DragosIorgulescu DragosIorgulescu force-pushed the MI-252-discussed-comments-feed-layout branch from f58b623 to eb14676 Compare April 1, 2024 11:12
sshanzel
sshanzel reviewed Apr 1, 2024
View reviewed changes
packages/shared/src/components/CommentFeed.tsx
@@ -103,10 +103,7 @@ export default function CommentFeed<T>({
isFetchingNextPage={queryResult.isFetchingNextPage}
canFetchMore={checkFetchMore(queryResult)}
fetchNextPage={queryResult.fetchNextPage}
className={classNames(
'w-full',
isNewMobileLayout && isMainFeed && 'px-4',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What should this look like in control values? Can you also attach screenshot of the old UI? Just to make sure everything still looks normal.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure thing, added previous of the previous UI as well

sshanzel
sshanzel approved these changes Apr 1, 2024
View reviewed changes
Copy link
Member

@sshanzel sshanzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Kindly verify that the control still looks normal, we should be good here :shipit:

sshanzel
sshanzel requested changes Apr 1, 2024
View reviewed changes
Copy link
Member

@sshanzel sshanzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late request, I think the labels on the navigation for tablet is a bit bigger than expected.

@DragosIorgulescu
Copy link
Contributor Author

Sorry for the late request, I think the labels on the navigation for tablet is a bit bigger than expected.

@sshanzel not sure what you are referring to, could you elaborate? Which labels?

@sshanzel
Copy link
Member

sshanzel commented Apr 2, 2024

@DragosIorgulescu hi, sorry for the lack of clarity. These ones. In the Figma they're at typo-caption2, after inspecting the element, I think they're on typo-callout.

Screenshot 2024-04-02 at 5 28 59 PM

@DragosIorgulescu
Copy link
Contributor Author

@DragosIorgulescu hi, sorry for the lack of clarity. These ones. In the Figma they're at typo-caption2, after inspecting the element, I think they're on typo-callout.

@sshanzel thank you for the clarification 🙏 I updated this, however to me these look way tinier than designs now (even though I agree these are specified with typo-caption2 there. See below

Screenshot 2024-04-02 at 13 14 25

This feels like we should use typo-caption1 rather 🤔

@sshanzel
Copy link
Member

sshanzel commented Apr 2, 2024

This feels like we should use typo-caption1 rather

Yep, totally agree with this. Sometimes it really looks different from Figma, I think what you suggested it the sweet spot.

sshanzel
sshanzel approved these changes Apr 2, 2024
View reviewed changes
Copy link
Member

@sshanzel sshanzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to change it to typo-caption1 - got nothing more on this, looks amazing! :shipit:

@DragosIorgulescu DragosIorgulescu merged commit 24727ee into main Apr 2, 2024
10 checks passed
@DragosIorgulescu DragosIorgulescu deleted the MI-252-discussed-comments-feed-layout branch April 2, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sshanzel sshanzel sshanzel approved these changes

@rebelchris rebelchris Awaiting requested review from rebelchris rebelchris is a code owner automatically assigned from dailydotdev/web-team

@omBratteng omBratteng Awaiting requested review from omBratteng omBratteng is a code owner automatically assigned from dailydotdev/web-team

@capJavert capJavert Awaiting requested review from capJavert capJavert is a code owner automatically assigned from dailydotdev/web-team

@kopancek kopancek Awaiting requested review from kopancek kopancek is a code owner automatically assigned from dailydotdev/web-team

@nensidosari nensidosari Awaiting requested review from nensidosari nensidosari is a code owner automatically assigned from dailydotdev/web-team

Assignees

@DragosIorgulescu DragosIorgulescu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DragosIorgulescu @sshanzel