Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename dagger to dagger-cue #79

Merged
merged 2 commits into from
Feb 13, 2023
Merged

rename dagger to dagger-cue #79

merged 2 commits into from
Feb 13, 2023

Conversation

marcosnils
Copy link
Contributor

@marcosnils marcosnils commented Dec 1, 2022

waiting on:

fixes #78

this will require releasing a new major version since it breaks backwards compat.

Signed-off-by: Marcos Lilljedahl marcosnils@gmail.com

@marcosnils marcosnils force-pushed the fix/dagger_cue_url branch 6 times, most recently from 3524244 to 7e4ac76 Compare December 1, 2022 18:53
@gerhard
Copy link
Member

gerhard commented Dec 7, 2022

WDYT @marcosnils, should we close this in favour of #80? Until we have a dagger-cue v0.3 - specifically dagger/dagger#3565 - I don't think that we should invest more time in the migration. How do you think about this @shykes? cc @jlongtine

@jlongtine
Copy link

@gerhard I agree.

@marcosnils
Copy link
Contributor Author

marcosnils commented Dec 12, 2022

Agree, I thought the cue-sdk branch had a way to build dagger-cue without all the new refactoring stuff in case we needed to ship a bugfix or something. If that's not the case, in this case this PR can be closed as IIUC, the current cue-sdk branch is not complete and is not intended to be used from source yet. Is that correct @jlongtine ?

@jlongtine
Copy link

jlongtine commented Dec 12, 2022

Agree, I thought the cue-sdk branch had a way to build dagger-cue without all the new refactoring stuff in case we needed to ship a bugfix or something. If that's not the case, in this case this PR can be closed as IIUC, the current cue-sdk branch is not complete and is not intended to be used from source yet. Is that correct @jlongtine ?

The current cue-sdk branch contains the v0.2/Europa codebase. So, it is intended to be used in its current state.

I'm pretty sure the current build method is using go-releaser.

@marcosnils
Copy link
Contributor Author

@jlongtine but I thought the cue-sdk branch also had all your in-progress work to migrate to cloak? Is that done already?

@jlongtine
Copy link

@jlongtine but I thought the cue-sdk branch also had all your in-progress work to migrate to cloak? Is that done already?

Only on my fork. Hasn't been merged. Not done. There are engine features that aren't finished yet that cause some issues for some Europa features.

@marcosnils
Copy link
Contributor Author

Only on my fork. Hasn't been merged. Not done. There are engine features that aren't finished yet that cause some issues for some Europa features.

got it. In that case, leaving that Dockerifle there is useful in case we need to push a fix to Europa that someone might need in their CI which is using the dagger-for-github action. I think it's very unlikely to happen, but leaving the Dockerfile there doesn't hurt.

fixes #78

Signed-off-by: Marcos Lilljedahl <marcosnils@gmail.com>
@marcosnils marcosnils force-pushed the fix/dagger_cue_url branch 2 times, most recently from ed4449f to 0c5061a Compare February 13, 2023 19:21
Signed-off-by: Marcos Lilljedahl <marcosnils@gmail.com>
@marcosnils marcosnils merged commit 2572459 into main Feb 13, 2023
@marcosnils marcosnils deleted the fix/dagger_cue_url branch February 13, 2023 20:08
jpadams pushed a commit that referenced this pull request Nov 13, 2023
* rename dagger to dagger-cue
fixes #78

Signed-off-by: Marcos Lilljedahl <marcosnils@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move dagger binary to dagger-cue
3 participants