Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollback breakage caused by Dagger CLI 0.3 release #80

Closed
shykes opened this issue Dec 6, 2022 · 3 comments · Fixed by #81
Closed

Rollback breakage caused by Dagger CLI 0.3 release #80

shykes opened this issue Dec 6, 2022 · 3 comments · Fixed by #81
Assignees

Comments

@shykes
Copy link

shykes commented Dec 6, 2022

Problem

We recently released a new Dagger CLI, version 0.3, which is a hard breaking change from 0.2. There is a migration path in preparation (using a new CLI called dagger-cue which is drop-in compatible with 0.2), that was meant to be rolled out soon.

But we accidentally broke users of the current github action now, without warning, by auto-updating this action to dagger 0.3. This should be immediately reversed regardless of future migration plans.

Solution

Change the latest version of this action @v3 to pin to dagger 0.2, instead of latest.

This should resolve the immediate issue for users of the Github Action, and allow us to finish planning a proper migration path.

Thank you @fredleger for alerting us and we apologize for the poor experience!

gerhard added a commit to gerhard/dagger-for-github that referenced this issue Dec 6, 2022
Since we published https://github.com/dagger/dagger/releases/tag/v0.3.6
(Nov. 30, 2022), this action started downloading that version (i.e.
`latest`), which resulted in breakage, as described in the issue that
this fixes.

As soon as all tests pass and this gets the OK + merge, we should:
1. Cut a new release for this action (I am thinking v3.2.0)
2. Update the v3 tag to point to this new version

That should fix this for all existing GitHub Actions users without any
intervention on their part.

Fixes:
- dagger#80

Signed-off-by: Gerhard Lazu <gerhard@dagger.io>
gerhard added a commit to gerhard/dagger-for-github that referenced this issue Dec 6, 2022
Since we published https://github.com/dagger/dagger/releases/tag/v0.3.6
(Nov. 30, 2022), this action started downloading that version (i.e.
`latest`), which resulted in breakage, as described in the issue that
this fixes.

As soon as all tests pass and this gets the OK + merge, we should:
1. Cut a new release for this action (I am thinking v3.2.0)
2. Update the v3 tag to point to this new version

That should fix this for all existing GitHub Actions users without any
intervention on their part.

Fixes:
- dagger#80

Signed-off-by: Gerhard Lazu <gerhard@dagger.io>
gerhard added a commit that referenced this issue Dec 6, 2022
Since we published https://github.com/dagger/dagger/releases/tag/v0.3.6
(Nov. 30, 2022), this action started downloading that version (i.e.
`latest`), which resulted in breakage, as described in the issue that
this fixes.

As soon as all tests pass and this gets the OK + merge, we should:
1. Cut a new release for this action (I am thinking v3.2.0)
2. Update the v3 tag to point to this new version

That should fix this for all existing GitHub Actions users without any
intervention on their part.

Fixes #80

Signed-off-by: Gerhard Lazu <gerhard@dagger.io>
@gerhard
Copy link
Member

gerhard commented Dec 6, 2022

Hey @fredleger! Can you confirm that the latest dagger/dagger-for-github@v3 fixes your issue?

FWIW https://github.com/dagger/dagger-for-github/releases/tag/v3.2.0

@fredleger
Copy link

I just roll backed my changes from this morning, and it's working like a charm 🎉

Now i'm just waiting for asdf plugin for dagger-cue to test the dropin replacement of previous dagger cli on my laptop :-)
Thanks for the follow up

@gerhard
Copy link
Member

gerhard commented Dec 7, 2022

Sure thing! Thanks for the quick reply 🏎

jpadams pushed a commit that referenced this issue Nov 13, 2023
Since we published https://github.com/dagger/dagger/releases/tag/v0.3.6
(Nov. 30, 2022), this action started downloading that version (i.e.
`latest`), which resulted in breakage, as described in the issue that
this fixes.

As soon as all tests pass and this gets the OK + merge, we should:
1. Cut a new release for this action (I am thinking v3.2.0)
2. Update the v3 tag to point to this new version

That should fix this for all existing GitHub Actions users without any
intervention on their part.

Fixes #80

Signed-off-by: Gerhard Lazu <gerhard@dagger.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants