[pull] master from nodejs:master #1193

pull · 2021-03-30T03:28:21Z

See Commits and Changes for more details.

Can you help keep this open source service alive? 💖 Please sponsor : )

[top-level-await] Implement the new post-order requirement for async subgraphs Refs: v8/v8@f19142e PR-URL: #37864 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

Because of lazy loading, running promisified timers tests for setTimeout and setImmediate from the same file means that there is a piece of code that doesn't get covered. Split into separate files to cover everything. Refs: https://coverage.nodejs.org/coverage-290c158018ac0277/lib/timers.js.html#L269 PR-URL: #37943 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

PR-URL: #37968 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

todo · 2021-03-30T03:28:24Z

(syg): Update to actual spec link once merged.

node/deps/v8/src/execution/isolate.h

Lines 1373 to 1378 in 7823759

    
           // TODO(syg): Update to actual spec link once merged. 
        
           // 
        
           // According to the spec, modules that depend on async modules (i.e. modules 
        
           // with top-level await) must be evaluated in order in which their 
        
           // [[AsyncEvaluating]] flags were set to true. V8 tracks this global total 
        
           // order with next_module_async_evaluating_ordinal_. Each module that sets its

This comment was generated by todo based on a `TODO` comment in `7823759` in #1193. cc @nodejs.

todo · 2021-03-30T03:28:27Z

(benjamingr) - refactor to use getEventListeners when nodejs#35991 lands

node/test/parallel/test-timers-immediate-promisified.js

Lines 9 to 14 in 7823759

    
           // TODO(benjamingr) - refactor to use getEventListeners when #35991 lands 
        
           const { NodeEventTarget } = require('internal/event_target'); 
        
           const timerPromises = require('timers/promises'); 
        
           const setPromiseImmediate = promisify(timers.setImmediate);

This comment was generated by todo based on a `TODO` comment in `7823759` in #1193. cc @nodejs.

todo · 2021-03-30T03:28:30Z

(benjamingr) - refactor to use getEventListeners when nodejs#35991 lands

node/test/parallel/test-timers-timeout-promisified.js

Lines 9 to 14 in 7823759

    
           // TODO(benjamingr) - refactor to use getEventListeners when #35991 lands 
        
           const { NodeEventTarget } = require('internal/event_target'); 
        
           const timerPromises = require('timers/promises'); 
        
           const setPromiseTimeout = promisify(timers.setTimeout);

This comment was generated by todo based on a `TODO` comment in `7823759` in #1193. cc @nodejs.

Original commit message: fix "the the" typo in README.md file Refs: nodejs/cjs-module-lexer@22093e7 PR-URL: #37895 Reviewed-By: Pooja D P <Pooja.D.P@ibm.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com>

This completes code coverage for v8.js. Refs: https://coverage.nodejs.org/coverage-290c158018ac0277/lib/v8.js.html#L240 PR-URL: #37955 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Fixes: #37862 PR-URL: #37877 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

Clarify the inner workings of .kill on Windows, since termination signals are not available there. Fixes: #34858 PR-URL: #34867 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

Notable changes The legacy HTTP parser is runtime deprecated: - The legacy HTTP parser, selected by the `--http-parser=legacy` command line option, is deprecated with the pending End-of-Life of Node.js 10.x (where it is the only HTTP parser implementation provided) at the end of April 2021. It will now warn on use but otherwise continue to function and may be removed in a future Node.js 12.x release. - The default HTTP parser based on llhttp is not affected. By default it is stricter than the now deprecated legacy HTTP parser. If interoperability with HTTP implementations that send invalid HTTP headers is required, the HTTP parser can be started in a less secure mode with the `--insecure-http-parser` command line option. ES Modules: - ES Modules are now considered stable. node-api: - Updated to node-api version 8 and added an experimental API to allow retrieval of the add-on file name. New API's to control code coverage data collection: - `v8.stopCoverage()` and `v8.takeCoverage()` have been added. New API to monitor event loop utilization by Worker threads - `worker.performance.eventLoopUtilization()` has been added. PR-URL: #37797

guybedford and others added 3 commits March 29, 2021 23:33

deps: backport v8 f19142e6

8e46568

[top-level-await] Implement the new post-order requirement for async subgraphs Refs: v8/v8@f19142e PR-URL: #37864 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

deps: upgrade npm to 7.7.6

7823759

PR-URL: #37968 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

pull bot added the ⤵️ pull label Mar 30, 2021

peZhmanParsaee and others added 5 commits March 30, 2021 10:12

url: forbid pipe in URL host

4197555

Fixes: #37862 PR-URL: #37877 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

pull bot merged commit 30fe4ed into daddyfatstacksBIG:master Mar 30, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[pull] master from nodejs:master #1193

[pull] master from nodejs:master #1193

pull bot commented Mar 30, 2021 •

edited

Loading

todo bot commented Mar 30, 2021

todo bot commented Mar 30, 2021

todo bot commented Mar 30, 2021

[pull] master from nodejs:master #1193

[pull] master from nodejs:master #1193

Conversation

pull bot commented Mar 30, 2021 • edited Loading

todo bot commented Mar 30, 2021

(syg): Update to actual spec link once merged.

This comment was generated by todo based on a TODO comment in 7823759 in #1193. cc @nodejs.

todo bot commented Mar 30, 2021

(benjamingr) - refactor to use getEventListeners when nodejs#35991 lands

This comment was generated by todo based on a TODO comment in 7823759 in #1193. cc @nodejs.

todo bot commented Mar 30, 2021

(benjamingr) - refactor to use getEventListeners when nodejs#35991 lands

This comment was generated by todo based on a TODO comment in 7823759 in #1193. cc @nodejs.

pull bot commented Mar 30, 2021 •

edited

Loading

This comment was generated by todo based on a `TODO` comment in `7823759` in #1193. cc @nodejs.

This comment was generated by todo based on a `TODO` comment in `7823759` in #1193. cc @nodejs.

This comment was generated by todo based on a `TODO` comment in `7823759` in #1193. cc @nodejs.