Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

URL: Forbid | (pipe) in URL host #37862

Closed
jasnell opened this issue Mar 22, 2021 · 1 comment · Fixed by #37877
Closed

URL: Forbid | (pipe) in URL host #37862

jasnell opened this issue Mar 22, 2021 · 1 comment · Fixed by #37877
Labels
confirmed-bug Issues with confirmed bugs. whatwg-url Issues and PRs related to the WHATWG URL implementation.

Comments

@jasnell
Copy link
Member

jasnell commented Mar 22, 2021

Refs: whatwg/url#589

This should not be allowed per recent spec change: new URL('http://exa|mple.org');
@jasnell jasnell mentioned this issue Mar 22, 2021
Merged
3 tasks
@jasnell jasnell added confirmed-bug Issues with confirmed bugs. whatwg-url Issues and PRs related to the WHATWG URL implementation. labels Mar 22, 2021
RaisinTen added a commit to RaisinTen/node that referenced this issue Mar 23, 2021
@RaisinTen
url: forbid pipe in URL host
22c8109 
Fixes: nodejs#37862
@RaisinTen RaisinTen mentioned this issue Mar 23, 2021
Merged
@RaisinTen
Copy link
Contributor

PR: #37877

@Trott Trott closed this as completed in 4197555 Mar 30, 2021
MylesBorins pushed a commit that referenced this issue Apr 4, 2021
@RaisinTen @MylesBorins
url: forbid pipe in URL host
570fbce 
Fixes: #37862

PR-URL: #37877
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
confirmed-bug Issues with confirmed bugs. whatwg-url Issues and PRs related to the WHATWG URL implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

url: forbid pipe in URL host RaisinTen/node
2 participants
@jasnell @RaisinTen