Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update jQuery #357

Closed
wants to merge 1 commit into from
Closed

update jQuery #357

wants to merge 1 commit into from

Conversation

OCram85
Copy link
Contributor

@OCram85 OCram85 commented May 24, 2018

Updates jQuery as first preperation step for GDPR compliance.

@abelcheung
Copy link
Contributor

Please forget previous comment since I haven't checked out the umbrella task at that time. Looks like more than technical issue have to be considered as well.

@abelcheung
Copy link
Contributor

Confirmed, this patch can't be applied. Bootstrap 3.x explicitly don't support JQuery 3, only accepts ≥ 1.9.1 and 2.x.

@daattali
Copy link
Owner

Can't be applied *until bootstrap is updated

@danielmpetrov
Copy link
Contributor

Confirmed, this patch can't be applied. Bootstrap 3.x explicitly don't support JQuery 3, only accepts ≥ 1.9.1 and 2.x.

Boostrap 3.3.7 introduced support for JQuery 3, so updating to the latest Boostrap 3 version (currently v3.4.1) will do the trick.

@daattali
Copy link
Owner

Closing this for now, if bootstrap will be upgraded then we can revisit

@daattali daattali closed this Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants