Update to Bootstrap 4

[kulbhushanchand]

There are some issues when using latest bootstrap from cdnjs server. Here is the link to closed issue .
The theme works well on bootstrap ver 3.3.2 for both js and css.
However if I may request to update the repository to use the latest bootstrap, would it be possible, and right now I have not the expertise to do so.

[OCram85]

Upgrading to bootstrap 4 would cause a complete rework of the theme. Since bootstrap 4 itself is a rework of the framework, the majority of components changed.

[kulbhushanchand]

Thanks for the feedback. Is it possible to make it free from bootstrap via custom css, like this theme - https://github.com/mmistakes/minimal-mistakes

[OCram85]

I personally think using the bootstrap framework for beautiful-jekyll has 2 huge advantages:

• Customization to individual needs is much easier with a detailed underlying component based framework.
• Using bootstrap guarantees you the help of a big community.

Like already said, it's only my personal opinion. But maybe it could be worth thinking about a reboot for this theme with bootstrap 4 - at a given time.

[daattali]

@kulbhushan-chand thanks for your suggestions. I don't think the theme will ever be completely standalone, using bootstrap as a core theme adds a lot of value and consistency. While I don't see the removal of bootstrap happening, upgrading to bootstrap 4 may happen in the future

[kulbhushanchand]

@OCram85 @daattali Thanks for your feedback. You are right about bootstrap. Hope we will soon see the latest addition of bootstrap 4.

[danielmpetrov]

Would an update to the latest Bootstrap 3 (v3.3.2 -> v3.4.1) be a welcome PR?

[daattali]

@danielmpetrov is there a big benefit to upgrading within bootstrap 3? I'm not too familiar with the new features of 3.4 vs 3.3

[danielmpetrov]

@daattali Mostly bug fixes. It will also enable the theme to upgrade jQuery to version 3, which brings security fixes. There is an open PR for this as well - #357

[daattali]

Ah yes I do see that comment you made there. Are there any regression bugs or behaviour changes? I'd be happy to update to the latest bootstrap 3 if you can test it out a bit and make sure there are no breaking changes!

[danielmpetrov]

Since it's a point release, there wouldn't be any breaking changes, but I share your concern @daattali. I can go through it in the upcoming days and open a PR if it works out.

[daattali]

Perfect. Yes I don't anticipate big (or any) problems, but because of the number of users affected with any change, I try to be very cautious, so some testing would be a good idea

…

--- Dean Attali President & CEO AttaliTech Ltd http://AttaliTech.com <http://attalitech.com>

On Tue, 23 Jul 2019 at 12:33, Daniel Petrov ***@***.***> wrote: Since it's a point release, there wouldn't be any breaking changes, but I share your concern @daattali <https://github.com/daattali>. I can go through it in the upcoming days and open a PR if it works out. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#384?email_source=notifications&email_token=AAHIQFG73WKO6GI2MDGGNN3QA4XGRA5CNFSM4FPEVQWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2TWLRI#issuecomment-514287045>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAHIQFFVWBUYQYYBGERMAALQA4XGRANCNFSM4FPEVQWA> .

[daattali]

I've started the work on migrating to bs4 in a bs4 branch. It's a lot more work than I imagined, there are a lot of components that break and need to be rewritten. If anybody wants to help, PRs are welcome.

[daattali]

Beautiful Jekyll now uses bootstrap 4.4.1