-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI updates #25
CI updates #25
Conversation
@AhmetCanSolak Can you rebase to Also I wonder if there is a way of silencing the doc string line length issue. #14 took care of the code formatting, but fixing doc string line breaks will take manual effort. |
I updated the branch and added the required black and isort fixes @ziw-liu . Let me know if you are happy with proposed changes on the action tasks, so accordingly we can merge and move forward with other PRs. |
@AhmetCanSolak Can you Not a big deal, but it would also be nice to have the coverage job to display results in PR. |
@AhmetCanSolak Also want to confirm that we don't need to edit |
Lint task is failing and that cancels any task that depends on it. I introduced this change intentionally to avoid wasting action hours, I will merge this PR and make a follow-up for addressing linting issues. |
Hi @AhmetCanSolak, have you started with this? I'm preparing to rebase #31. |
I haven't got to it yet @ziw-liu , I can probably do that next week, if you think you can move it before that go for it. |
@AhmetCanSolak Thanks for letting me know! |
This PR addresses the concerns raised in #24 so far and will not be merged before discussion is finalized.