Issue #6216 -- have .its() receive the number 0 as parameter

[datner]

• Closes An Its() function cannot access index of zero. #6216

User facing changelog

its() now supports 0 as a value for indexes or object keys

Additional details

Many times a developer will intuitively reach for the first item in an array for tests or checks
(or for anything if I'm honest), and until now trying to reach that property using .its(0) threw an error.
Now developers world-wide would be able to check the first index of their array in a cypress environment. Well, I'm sure you could still have done it with .its("0") but just isn't as cool.

The tests check for edge cases, other than that I didn't do anything unexpected

How has the user experience changed?

this didn't work, now it does, it's the intuitive thing to do, so it's pretty chill

 cy.wrap(["cake","hamburger"]).its(0).should("eq","cake");

PR Tasks

• Have tests been added/updated?
• Has a PR for user-facing changes been opened in cypress-documentation?

Is there anything to add to cypress-documentation? This now works as planned, I didn't add any new features to the mental model of how .its() operates

[cypress-bot]

Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.

• Please write [WIP] in the title of your Pull Request if your PR is not ready for review - someone will review your PR as soon as the [WIP] is removed.
• Please familiarize yourself with the PR Review Checklist and feel free to make updates on your PR based on these guidelines.

PR Review Checklist

If any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'.

User Experience

• The feature/bugfix is self-documenting from within the product.
• The change provides the end user with a way to fix their problem (no dead ends).

Functionality

• The code works and performs its intended function with the correct logic.
• Performance has been factored in (for example, the code cleans up after itself to not cause memory leaks).
• The code guards against edge cases and invalid input and has tests to cover it.

Maintainability

• The code is readable (too many nested 'if's are a bad sign).
• Names used for variables, methods, etc, clearly describe their function.
• The code is easy to understood and there are relevant comments explaining.
• New algorithms are documented in the code with link(s) to external docs (flowcharts, w3c, chrome, firefox).
• There are comments containing link(s) to the addressed issue (in tests and code).

Quality

• The change does not reimplement code.
• There's not a module from the ecosystem that should be used instead.
• There is no redundant or duplicate code.
• There are no irrelevant comments left in the code.
• Tests are testing the code’s intended functionality in the best way possible.

Internal

• The original issue has been tagged with a release in ZenHub.

[claassistantio]

All committers have signed the CLA.

[flotwig]

Thanks for opening this PR! The changes look good, but I noticed a few minor things that should be fixed before this is merged.

[bahmutov]

The check for index - what does it do if one passes “-1”? Ughh JavaScript allows so much stuff

…

Sent from my iPhone

On Jan 24, 2020, at 10:22, Zach Bloomquist ***@***.***> wrote:  @flotwig requested changes on this pull request. Thanks for opening this PR! The changes look good, but I noticed a few minor things that should be fixed before this is merged. In packages/driver/test/cypress/integration/commands/connectors_spec.coffee: > @@ -813,6 +813,11 @@ describe "src/cy/commands/connectors", -> it "works with numerical indexes", -> cy.wrap(['foo', 'bar']).its(1).should('eq', 'bar') + it "works with 0 as a value if object has property 0", -> add a test for cy.invoke, since it uses the same connectors logic, cy.invoke(0) should work too In packages/driver/src/cy/commands/connectors.coffee: > @@ -179,7 +179,8 @@ module.exports = (Commands, Cypress, cy, state, config) -> consoleProps: -> Subject: subject - if not str + ## check for false positive (negative?) with 0 given as index + if not str and str isnt 0 since this logic is shared between line 256 and this line, move it to a named function for clarity. maybe something like this: isObjectKey = (i) => i or i is 0 In packages/driver/src/cy/commands/connectors.coffee: > @@ -251,9 +252,12 @@ module.exports = (Commands, Cypress, cy, state, config) -> previousProp = pathsArray[index - 1] valIsNullOrUndefined = _.isNil(acc) + ## to allow the falsy value 0 to be used + propIsValid = !!prop or prop is 0 see comment on line 183 — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

[datner]

@bahmutov
I am still waiting for a reply on what to do on that occasion, my guess would be to just ignore it? it'll return undefined every time and thats not an issue, it's reality. Also lets object with the key "-1" still work

[datner]

Uhhh.. I am not really sure what to do about this.... I used the same computer and user and repo and set up, nothing changed between the commits..?

[flotwig]

Uhhh.. I am not really sure what to do about this.... I used the same computer and user and repo and set up, nothing changed between the commits..?

It looks like you made the first commits with a gmail email address, then you made the last two commits with an email address (contact [at] datner [dot] me) which is not yet linked to your GitHub account.

Add this email to your GitHub account and confirm it, then ask the CLA assistant to retry, it should work once the 2nd email is associated with your GitHub: https://github.com/settings/emails

I am still waiting for a reply on what to do on that occasion, my guess would be to just ignore it? it'll return undefined every time and thats not an issue, it's reality. Also lets object with the key "-1" still work

Yup, negative indices are valid, this is good.

[flotwig]

Thanks!

[datner]

It looks like you made the first commits with a gmail email address, then you made the last two commits with an email address (contact [at] datner [dot] me) which is not yet linked to your GitHub account.

Very odd.. I never used that email for git. But done