An Its() function cannot access index of zero.

[Misxy]

Current behavior:

From the tutorial on the official website (https://docs.cypress.io/api/commands/its.html) when I have used with an array following the example I have found an issue of the function. The function could access indices from indices one to last indices of the array. However, when I have used the indices zero with the function the compiler have an error.

Desired behavior:

The function have been access by indices zero to the last indices of the example array.

Test code to reproduce

cy.wrap(['Wai Yan', 'Yu']).its(1).should('eq', 'Yu') // true
cy.wrap(['Wai Yan', 'Yu']).its(0).should('eq', 'Yu') // CypressError: cy.its() expects the propertyName argument to have a value.

Versions

Cypress version (Installed via npm) : 3.8.2
Os: Windows 10

[jennifer-shehane]

Yes, this is a bug. Good catch.

Being able to use indices for .its() was introduced in 3.7.0 in this PR: #5755, but then the .its() command had some more changes made in 3.8.0 in this PR: #5519

It seems that the 0 property for index is being evaluated as falsey and throwing an error as if there is no 1st argument given to the command.

The error in logic was added here: https://github.com/cypress-io/cypress/pull/5519/files#diff-5b34517122a03995ae6793f0a8d18797R182 where it does a simple if (!str) check, which will evaluate as falsey without considering that 0 is a valid expected argument. cc @gabbersepp

This code below needs to be fixed to address this and a test that uses .its(0) needs to be added.

https://github.com/cypress-io/cypress/blob/develop/packages/driver/src/cy/commands/connectors.coffee#L184:L184

This actually appears to have also been a bug in 3.7.0 release, as it also does not return the 0 index (although does not error), so there may be some more code necessary to make this work. cc @flotwig

Reproducible Code

it('failure', () => {
  cy.wrap(['Wai Yan', 'Yu']).its(1).should('eq', 'Yu') 
  cy.wrap(['Wai Yan', 'Yu']).its(0).should('eq', 'Wai Yan') 
})

3.7.0

3.8.0

[datner]

I am currently doing this one, the project is a bit overwhelming for me so I might get this wrong so please be patient with me :) (also writing coffeescript on the fly so thats cool).

I'm actually done but the pre-commit hook is breaking on me, so, I'm dealing with that

[cypress-bot]

The code for this is done in cypress-io/cypress#6234, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

[flotwig]

Released in 4.0.0.