Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch to electron-builder to code sign and notarize Cypress application #6013

Merged
merged 105 commits into from
Mar 25, 2020
Merged

switch to electron-builder to code sign and notarize Cypress application #6013

merged 105 commits into from
Mar 25, 2020
+1,532 −799

Conversation

bahmutov
Copy link
Contributor

@bahmutov bahmutov commented Dec 19, 2019 •
edited by jennifer-shehane
Loading

User facing changelog

  • when running Cypress on Mac OS, there should be no warnings from Mac security tools
  • Mac application is signed using the new Cypress.io application certificate
  • Update execa from 1.0.0 to 4.0.0

Additional details

Mac OS Catalina requires the apps to be distributed to use new hardened runtime and be notarized. We also need to switch to the new company application certificate to code sign the app, instead of a personal certificate that is close to expiring

How has the user experience changed?

No changes

PR Tasks

  • Has the original issue been tagged with a release in ZenHub?

Details

stretch / unimportant

  • build on Mac does not create extra files / zip archives
  • Linux build does not create extra files / zip archives

flotwig and others added 30 commits December 2, 2019 12:40
@flotwig
electron@7.x
1cae916
@flotwig
node12.8.1-chrome78-ff70
db2d521
@flotwig
Revert "node12.8.1-chrome78-ff70" for now
57fe764 
This reverts commit db2d521.
@flotwig
update sendCommand to log on all sendcommands
2bef520
@flotwig
promisification in 6.x
27bdd97
@flotwig
Revert "Revert "node12.8.1-chrome78-ff70" for now"
8097a81 
This reverts commit 57fe764.
@flotwig
Merge branch 'decaf-server-lib-automation' into electron-upgrade
527b203
@flotwig
fix sendcommand
0282b98
@flotwig
fix cdp in electron
12e5e48
@flotwig
fix desktop-gui test
9710805
@flotwig
skip tests that will be fixed by #4973
176b18c
@flotwig
bump MAX_ALLOWED_FILE_SIZE :/
3d996ff
@flotwig
update electron browser spec
dc577e9
@flotwig
make new dialog code null-proof
50320d8
@brian-mann
add failing e2e test for issue 5475
226fd6e
@brian-mann
bump electron packager
323bae5
@brian-mann
add e2e snapshot
0850372
@flotwig
Merge branch 'develop' into electron-upgrade
bfc9005
@flotwig
update deprecated electron getters/setters
0bf8621 
https://github.com/electron/electron/blob/7-1-x/docs/api/modernization/property-updates.md
@bahmutov
build and test on Mac
77b362e
@bahmutov
use electron-builder 20.41.0
ec9335d 
that adds an option to use hardened Mac OS, which is necessary
for code notarization later.

See https://github.com/electron-userland/electron-builder/releases/tag/v20.41.0
and electron-userland/electron-builder#3858
@bahmutov
electron-builder and pass hardenedRuntime: true
d7e0423
@bahmutov
uncomment build
9c4c9c7
@bahmutov
upload built binary on mac
89460cc
@bahmutov
back to 20.41.0, trying after sign hook without success
755c7e4
@bahmutov
Merge branch 'develop' into electron-upgrade
ba328aa
@bahmutov
use current electron-builder alias instead of build
ab9a50a
@bahmutov
retry smoke test on first failure
d98edfa
@bahmutov
testing
89d7204
@bahmutov
Merge branch 'develop' into try-new-electron-sign
e690fc6
@bahmutov bahmutov requested review from brian-mann and kuceb March 6, 2020 14:14
@bahmutov
Copy link
Contributor Author

  • blocked: yarn hoists ffmpeg installer out of packages/server, which seems to be a mistake since it is a production dependency

@bahmutov
Copy link
Contributor Author 

$ ls node_modules/\@ffmpeg-installer/
darwin-x64
~/git/cypress on try-new-electron-sign*
$ ls packages/server/node_modules/\@ffmpeg-installer/
ffmpeg

@bahmutov
Copy link
Contributor Author

build and signing is working again, would be nice to merge and get Mac users to install pre-releases this week before using the new code signing certificate

@brian-mann brian-mann merged commit abf4d85 into develop Mar 25, 2020
@cypress-bot cypress-bot bot mentioned this pull request Mar 25, 2020
Closed
@jennifer-shehane jennifer-shehane mentioned this pull request Mar 26, 2020
Closed
@bahmutov bahmutov mentioned this pull request Mar 26, 2020
Closed
@jennifer-shehane jennifer-shehane mentioned this pull request Apr 7, 2020
Closed
@snyk-bot snyk-bot mentioned this pull request Apr 16, 2020
Merged
@minijus minijus mentioned this pull request May 13, 2021
Closed
@emilyrohrbough emilyrohrbough deleted the try-new-electron-sign branch August 1, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brian-mann brian-mann brian-mann approved these changes

@kuceb kuceb Awaiting requested review from kuceb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

“Cypress” can’t be opened because Apple cannot check it for malicious software.
4 participants
@bahmutov @brian-mann @kuceb @flotwig