Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when opening Cypress in develop branch in Mac - #6850

Closed
jennifer-shehane opened this issue Mar 26, 2020 · 1 comment
Closed

Error when opening Cypress in develop branch in Mac - #6850

jennifer-shehane opened this issue Mar 26, 2020 · 1 comment

Comments

@jennifer-shehane
Copy link
Member

jennifer-shehane commented Mar 26, 2020

Current behavior:

When running yarn start in Cypress in develop branch on my Mac Mojave 10.14.6 - this error always displays and I cannot proceed:

execa_1.default.stdout is not a function

Screen Shot 2020-03-26 at 11 58 06 AM

It looks like @bahmutov touched this darwin/utils.js file in #6013 This may be masking the real error that's not bubbling up.

https://github.com/cypress-io/cypress/pull/6013/files#diff-8196058edd4df324a343fc7abaa81f9b

Looks like execa was updated in this PR - this should be noted in the User Changelog of the PR for all dependency updates and ideally done in a separate PR so we can isolate the changes of the dep update.

Big question

Why didn't our tests catch this??

Stack trace:

[object Object]
    at mdfind (/Users/jennifer/Dev/cypress/packages/launcher/lib/darwin/util.js:50:10)
    at tryMdFind (/Users/jennifer/Dev/cypress/packages/launcher/lib/darwin/util.js:72:16)
    at Object.findApp (/Users/jennifer/Dev/cypress/packages/launcher/lib/darwin/util.js:79:12)
    at Object.detect (/Users/jennifer/Dev/cypress/packages/launcher/lib/darwin/index.js:93:19)
    at lookup (/Users/jennifer/Dev/cypress/packages/launcher/lib/detect.js:48:19)
    at checkOneBrowser (/Users/jennifer/Dev/cypress/packages/launcher/lib/detect.js:88:12)
    at /Users/jennifer/Dev/cypress/packages/launcher/lib/detect.js:58:20
    at processImmediate (internal/timers.js:439:21)
From previous event:
    at fn (cypress:///./src/lib/ipc-bus.js:108:14)
    at ipcBus (cypress:///./src/lib/ipc-bus.js:127:10)
    at Object.ipc.<computed> [as openProject] (cypress:///./src/lib/ipc.js:29:69)
    at Object.openProject (cypress:///./src/projects/projects-api.js:175:67)
    at Project.componentDidMount (cypress:///./src/project/project.jsx:123:78)
    at commitLifeCycles (cypress:////Users/jennifer/Dev/cypress/node_modules/react-dom/cjs/react-dom.development.js:22101:22)
    at commitLayoutEffects (cypress:////Users/jennifer/Dev/cypress/node_modules/react-dom/cjs/react-dom.development.js:25344:7)
    at HTMLUnknownElement.callCallback (cypress:////Users/jennifer/Dev/cypress/node_modules/react-dom/cjs/react-dom.development.js:336:14)
    at Object.invokeGuardedCallbackDev (cypress:////Users/jennifer/Dev/cypress/node_modules/react-dom/cjs/react-dom.development.js:385:16)
    at invokeGuardedCallback (cypress:////Users/jennifer/Dev/cypress/node_modules/react-dom/cjs/react-dom.development.js:440:31)
    at commitRootImpl (cypress:////Users/jennifer/Dev/cypress/node_modules/react-dom/cjs/react-dom.development.js:25082:9)
    at unstable_runWithPriority (cypress:////Users/jennifer/Dev/cypress/node_modules/scheduler/cjs/scheduler.development.js:697:12)
    at runWithPriority$2 (cypress:////Users/jennifer/Dev/cypress/node_modules/react-dom/cjs/react-dom.development.js:12149:10)
    at commitRoot (cypress:////Users/jennifer/Dev/cypress/node_modules/react-dom/cjs/react-dom.development.js:24922:3)
    at finishSyncRender (cypress:////Users/jennifer/Dev/cypress/node_modules/react-dom/cjs/react-dom.development.js:24329:3)
    at performSyncWorkOnRoot (cypress:////Users/jennifer/Dev/cypress/node_modules/react-dom/cjs/react-dom.development.js:24307:9)
    at eval (cypress:////Users/jennifer/Dev/cypress/node_modules/react-dom/cjs/react-dom.development.js:12199:24)
    at unstable_runWithPriority (cypress:////Users/jennifer/Dev/cypress/node_modules/scheduler/cjs/scheduler.development.js:697:12)
    at runWithPriority$2 (cypress:////Users/jennifer/Dev/cypress/node_modules/react-dom/cjs/react-dom.development.js:12149:10)

Test code to reproduce

  • Pull develop
  • Run yarn start

Versions

  • pre-release in develop
  • Mac Mojave 10.14.6
  • Node.js v12.8.1
@jennifer-shehane jennifer-shehane added type: bug stage: needs investigating Someone from Cypress needs to look at this labels Mar 26, 2020
@jennifer-shehane
Copy link
Member Author

Fixed by running yarn clean-js in packages/launcher - there were leftover js files being read over the new ts files. thanks @bahmutov

@jennifer-shehane jennifer-shehane removed the stage: needs investigating Someone from Cypress needs to look at this label Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant