-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mention HTTP_PROXY if download error occurs; fall back to NPM's proxy… #4705
Conversation
flotwig
commented
Jul 12, 2019
•
edited
Loading
edited
- Fixes When the binary fails to download add a message about proxy #1662
- Fixes Add fallback to NPM proxy configuration when other proxy configuration is unavailable #4719
- Updates download error message
- Adds fallback to npm_config_proxy, npm_config_https_proxy
… config in install
This will download the binary but still fail when running actual Cypress tests because we don't check those same npm config env vars right? |
Should we update the docs to make mention of us respecting the |
~~ Correct, I think it makes sense to respect the npm config vars here because it's part of the
Never mind, let's just use it and assume that people aren't switching back and forth like that. I'll add add'l logging so that we can debug this issue if it does crop up.
The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- respect
npm_config
env vars if set when incypress run
orcypress open
- add nice debug logs for the proxy to indicate where/what set the values
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. I am wondering, should we have an example recipe that shows and tests the proxy env variable
@bahmutov I don't think so - proxies aren't really something that users desire to have setup - they are constraints that exist in their work environment that they have to conform to. It's not like "a feature" or anything. As long as we provide good documentation / error messaging, etc that help guide and direct those who are affected I think we're fine. Have we had anyone open issues or ask support questions in regards to how to utilize their proxies? I'm not aware of any TBH. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@flotwig this PR is actually doing two things - adding a message but also tapping into the npm config for proxy support. Can you open a separate issue for that (since it's a discrete thing that needs to be mentioned in the changelog and also noted in the docs).
Done, #4719 |