Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fallback to NPM proxy configuration when other proxy configuration is unavailable #4719

Closed
flotwig opened this issue Jul 15, 2019 · 2 comments · Fixed by #4705
Closed
Assignees

Comments

@flotwig
Copy link
Contributor

flotwig commented Jul 15, 2019

Add support for the proxy and https-proxy configuration variables in NPM to control Cypress's proxy configuration.

Users should still be able to do HTTP_PROXY= (empty string) to disable proxy usage altogether.

This should allow Cypress to "just work" when launched by proxy users who use NPM as a launcher.

This should also be added to the CLI so that it can use npm_config_proxy at npm install time.

@flotwig flotwig self-assigned this Jul 15, 2019
@cypress-bot cypress-bot bot added the stage: needs review The PR code is done & tested, needs review label Jul 15, 2019
@cypress-bot cypress-bot bot added stage: pending release and removed stage: needs review The PR code is done & tested, needs review labels Jul 15, 2019
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jul 15, 2019

The code for this is done in cypress-io/cypress#4705, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jul 29, 2019

Released in 3.4.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant