Skip to content

Conversation

ryanthemanuel
Copy link
Collaborator

@ryanthemanuel ryanthemanuel commented Oct 4, 2025

  • Closes

Additional details

Steps to test

How has the user experience changed?

PR Tasks


Note

Renames PromptOptions.excludeFromAI to redactValues, updates cy-prompt mount header to v2, and adjusts CircleCI filters/artifact persistence to target a new branch.

  • Types:
    • Rename PromptOptions field from excludeFromAI to redactValues in cli/types/cypress.d.ts.
  • Server:
    • Update header x-cypress-cy-prompt-mount-version from 1 to 2 in packages/server/lib/cloud/api/cy-prompt/get_cy_prompt_bundle.ts.
  • CI (CircleCI):
    • Switch workflow filters and artifact persistence checks from branch feat/cy-prompt to ryanm/fix/rename-exclude-from-ai in .circleci/src/pipeline/@pipeline.yml and workflows/@main.yml.

Written by Cursor Bugbot for commit f2639a8. This will update automatically on new commits. Configure here.

ryanthemanuel and others added 30 commits May 20, 2025 16:37
* feat: cy prompt infrastructure

* refactor and add tests

* refactor

* rename experimental config

* prompt

* fix test

* Update cy-prompt-development.md

* Update cy-prompt-development.md

* PR comments

* Update packages/server/lib/cloud/api/cy-prompt/get_cy_prompt_bundle.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* PR comments

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* chore: add cdp connection to cy prompt

* minor fix

* fix type build

* try to fix build

* Update packages/server/lib/browsers/browser-cri-client.ts

Co-authored-by: Bill Glesias <bglesias@gmail.com>

* Update packages/server/lib/browsers/browser-cri-client.ts

Co-authored-by: Bill Glesias <bglesias@gmail.com>

* do not support prompt in firefox or webkit

* rework timing of lifecycle

* refactor

* fix tests

* troubleshooting

* troubleshooting

* fix tests

* additional troubleshooting

* additional troubleshooting

* additional troubleshooting

* attempt to fix build

* add back

* debugging

* debugging

* debugging

* debugging

* clean up

* fix unit tests

* rework

---------

Co-authored-by: Bill Glesias <bglesias@gmail.com>
…#31803)

* chore: add promptBackend as an additional Cypress-attached function

* Update packages/app/src/runner/event-manager.ts

* update types

* fix types

* fix spacing

* refactor

* additional refactor

* fix type build

* fix build

* refactor

* reword messages

* fix

* debugging

* undo debugging

* PR comment

* fix tests

* fix tests

* fix tests

* fix test
* chore: add watcher for cy-prompt development

* test caching

* fix types
…31835)

* internal: (cy.prompt) handle errors better in the command definition

* internal: (cy.prompt) add timeout and handle loading errors more cleanly

* add process environment variable

* clean up test

* update JSDoc
* chore: handle errors

* Fix ts, add test

* Fix error title

* Fix ts

* Fix ts
* share error utils with cloud

* additional rework

* Fix command, add isOpenMode

* Add / fix test

* fix ts

---------

Co-authored-by: Ryan Manuel <ryanm@cypress.io>
…31904)

* chore: (cy.prompt) add infrastructure to support a Get Code modal

* fix tests

* fix code paths

* Update eject button styles

* handle errors

* update types

* Update packages/server/lib/socket-base.ts

* Fix cy test

* update readme

---------

Co-authored-by: estrada9166 <estrada9166@gmail.com>
* chore: (cy.prompt) refactor getTestsState to take a runnable id

* fix tests

* minor tweak
…31922)

* chore: (cy.prompt) add manifest for all of the cloud delivered files

* fix tests and remove environment variables

* update strategy

* fix build

* rework

* require manifest

* clean up

* refactor

* refactor

* Update packages/server/lib/cloud/cy-prompt/CyPromptLifecycleManager.ts

Co-authored-by: Matt Schile <mschile@cypress.io>

* fix test

---------

Co-authored-by: Matt Schile <mschile@cypress.io>
* feat: add cy prompt more info needed modal

* Reset promptStore

* additional things exposed for more info

* rework

* fix tests

* fix build

* fix types

* fix types

* Update packages/app/src/runner/event-manager.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* reefactor

* chore: (cy.prompt) rework the file save lifecycle

* rework types

* add unit tests

---------

Co-authored-by: estrada9166 <estrada9166@gmail.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…root in the cy.prompt modals (#32011)

* fix: (studio) ensure that we do not attach a vue ref to the react root in the studio panel

* fix test
Co-authored-by: Ryan Manuel <ryanm@cypress.io>
jennifer-shehane and others added 22 commits September 16, 2025 12:46
… outs (#32582)

* internal: (cy.prompt) various improvements to error messages and timeouts

* fix test

* remove dead code

* Update packages/driver/src/cy/commands/prompt/index.ts

* update prompt experiment description

* fix build

* fix tests

* fix tests

* fix test

* update error message

* Update packages/server/lib/experiments.ts

Co-authored-by: Tim Griesser <tgriesser10@gmail.com>

---------

Co-authored-by: Tim Griesser <tgriesser10@gmail.com>
…mpts in cy.origin (#32596)

* internal: (cy.prompt) ensure that get code can properly work with prompts in cy.origin

* additional tests

* additional tests

* Apply suggestions from code review

* code review comment

* fix merge

* fix merge

* Update packages/data-context/graphql/schemaTypes/index.ts
* chore: display custom link title

* Add test

* Pass docs as second argument of the error

* Revert changes

* Use openExternal for links

---------

Co-authored-by: Jennifer Shehane <jennifer@cypress.io>
* internal: (cy.prompt) do not retry on cert failures

* tests and clean up

* additional cleanup and add error message for prompt

* fix unit tests

* Update report_studio_error.ts

* Update packages/network/lib/agent.ts

* cursor comment

* fix build

* fix build

* fix test

* fix build

* fix build

* fix build

* fix build

* fix build

* revert

* Update packages/driver/src/cypress/error_messages.ts

* Update packages/driver/cypress/e2e/commands/prompt/prompt-initialization-error.cy.ts

* fix build
@ryanthemanuel ryanthemanuel changed the title Ryanm/fix/rename exclude from ai internal: rename excludeFromAI type Oct 4, 2025
cursor[bot]

This comment was marked as outdated.

Copy link

cypress bot commented Oct 4, 2025

cypress    Run #66192

Run Properties:  status check failed Failed #66192  •  git commit f2639a80bb: Update packages/frontend-shared/src/locales/en-US.json
Project cypress
Branch Review ryanm/fix/rename-exclude-from-ai
Run status status check failed Failed #66192
Run duration 23m 11s
Commit git commit f2639a80bb: Update packages/frontend-shared/src/locales/en-US.json
Committer Ryan Manuel
View all properties for this run ↗︎

Test results
Tests that failed  Failures 2
Tests that were flaky  Flaky 5
Tests that did not run due to a developer annotating a test with .skip  Pending 28
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 788
View all changes introduced in this branch ↗︎
UI Coverage  62.34%
  Untested elements 27  
  Tested elements 48  
Accessibility  98.98%
  Failed rules  0 critical   3 serious   1 moderate   0 minor
  Failed elements 19  

Tests for review

Failed  cypress\e2e\runner\runner.ui.cy.ts • 2 failed tests • app-e2e

View Output

Test Artifacts
src/cypress/runner > tests finish with correct state > no tests Test Replay Screenshots
src/cypress/runner > other specs > file with empty suites only displays no tests found Test Replay Screenshots
Flakiness  cypress\e2e\runner\runner.ui.cy.ts • 1 flaky test • app-e2e

View Output

Test Artifacts
src/cypress/runner > reporter interaction > user can stop test execution Test Replay Screenshots
Flakiness  cypress\e2e\runs.cy.ts • 1 flaky test • app-e2e

View Output

Test Artifacts
... > displays each run with correct information Test Replay Screenshots
Flakiness  cypress\e2e\cypress-origin-communicator.cy.ts • 1 flaky test • app-e2e

View Output

Test Artifacts
Cypress In Cypress Origin Communicator > primary origin memory leak prevention > cleans up the primaryOriginCommunicator events when navigating away from the /specs to /runs Test Replay Screenshots
Flakiness  cypress\e2e\runner\cloud-debug-filter.cy.ts • 1 flaky test • app-e2e

View Output

Test Artifacts
cloud debug test filtering > filter is maintained across cross-domain reinitialization Test Replay Screenshots
Flakiness  cypress\e2e\choose-a-browser.cy.ts • 1 flaky test • launchpad-e2e

View Output

Test Artifacts
Choose a browser page > System Browsers Detected > launches when --browser is passed alone through the command line Test Replay Screenshots

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants