-
Notifications
You must be signed in to change notification settings - Fork 3.4k
chore: create infrastructure to support backend function in cy.prompt #31803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
*/ | ||
prevUntil<E extends Node = HTMLElement>(element: E | JQuery<E>, filter?: string, options?: Partial<Loggable & Timeoutable>): Chainable<JQuery<E>> | ||
|
||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also took this opportunity to remove these types. We won't officially add them until we are ready to release the experiment
cypress
|
Project |
cypress
|
Branch Review |
ryanm/chore/add-prompt-backend
|
Run status |
|
Run duration | 18m 48s |
Commit |
|
Committer | Ryan Manuel |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
10
|
|
1232
|
|
0
|
|
32187
|
View all changes introduced in this branch ↗︎ |
UI Coverage
45.83%
|
|
---|---|
|
190
|
|
165
|
Accessibility
92.74%
|
|
---|---|
|
3 critical
9 serious
2 moderate
2 minor
|
|
695
|
packages/driver/src/cypress.ts
Outdated
} | ||
|
||
promptBackend (eventName, ...args) { | ||
return this.baseBackendRequestHandler('prompt:backend:request', eventName, ...args) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm curious we'd want to introduce so many places in the app where this could diverge vs bundling this logic up in a cloud call that handles what to do as well as telling the app if it should continue with non-cloud logic
Cloud {
backend (emitEventName: string, eventName, ...args)) {
if (!cloudService || !cloudService.isSupportedEvent(emitEventName)) {
return [true, null]
}
return [false, cloudService.handleEvent()]
}
}
private baseBackendRequestHandler (emitEventName: string, eventName, ...args) {
const [isAppBackendRequest, result] = await this.cloud.backend(.....) <-- initialized on start
if (!isAppBackendRequest) {
return result
}
return new Promise((resolve, reject) => {
}
)
backend (eventName, ...args) {
return this.baseBackendRequestHandler('backend:request', eventName, ...args)
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@emilyrohrbough makes a good point. Do we know if this is mostly for the experiment to iterate faster with plans to move it later to something a bit more stable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good point and I've refactored it a bit to minimize what is necessary on the app providing hooks to be more flexible in the cloud
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like some of the added tests are failing?
packages/driver/src/cypress.ts
Outdated
} | ||
|
||
promptBackend (eventName, ...args) { | ||
return this.baseBackendRequestHandler('prompt:backend:request', eventName, ...args) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@emilyrohrbough makes a good point. Do we know if this is mostly for the experiment to iterate faster with plans to move it later to something a bit more stable
let response | ||
|
||
try { | ||
response = await Cypress.backendRequestHandler( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe I'm missing something, but is this supposed to be Cypress.backend
or is the backendRequestNamespace
missing from this call?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah this should be backendRequestNamespace
not eventName
. Will update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The functionality is right, the name is confusing (wrong)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds the plumbing for cy.prompt
to send and receive backend requests by mirroring Cypress.backend
behavior.
- Introduces a new
addSocketListeners
API in the cy-prompt server types and manager - Hooks the cy-prompt lifecycle into the main socket server
- Updates driver code with a new
backendRequestHandler
and refactors the prompt command
Reviewed Changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
packages/types/src/config.ts | Removed experimentalPromptCommand from config types |
packages/server/lib/socket-base.ts | Dropped old backend:request handler and registered addSocketListeners |
packages/server/lib/cloud/cy-prompt/CyPromptManager.ts | Replaced handleBackendRequest with addSocketListeners |
packages/driver/src/cypress.ts | Added backendRequestHandler , refactored backend alias |
packages/driver/src/cy/commands/prompt/index.ts | Switched to createCyPrompt and improved error messages |
packages/app/src/runner/event-manager.ts | Delegated primary-origin socket events to handler |
Comments suppressed due to low confidence (5)
packages/types/src/config.ts:33
- The
ReceivedCypressOptions
type no longer includesexperimentalPromptCommand
, but code inproject-base.ts
still checks this flag. Please re-addexperimentalPromptCommand
to the Pick<> so the flag remains typed.
& Pick<Cypress.ResolvedConfigOptions, 'chromeWebSecurity' | ... | 'justInTimeCompile'>
packages/server/lib/socket-base.ts:455
- The backend:request listener was removed, so any non-prompt backend events will no longer be handled. Consider restoring or rewriting the logic to route
backend:request
events through the newaddSocketListeners
hook.
socket.on('backend:request', (eventName: string, ...args) => {
packages/driver/src/cy/commands/prompt/index.ts:21
- [nitpick] Error messages typically start with an uppercase letter. Consider capitalizing the first word for consistency (e.g.,
Error waiting for cy prompt bundle…
).
throw new Error('error waiting for cy prompt bundle to be downloaded and ready')
packages/driver/src/cy/commands/prompt/index.ts:15
- [nitpick] The name
initializedModule
is vague; consider renaming toinitializedCyPromptDriver
or similar to clarify its purpose.
let initializedModule: CyPromptDriverDefaultShape | null = null
packages/app/src/runner/event-manager.ts:801
- There's no existing unit test covering
handlePrimaryOriginSocketEvent
integration. Please add a test to verify that primary-origin backend events are properly forwarded.
Cypress.handlePrimaryOriginSocketEvent(Cypress, 'backend:request')
* Create cy-prompt-development.md * chore: cy prompt infrastructure (#31748) * feat: cy prompt infrastructure * refactor and add tests * refactor * rename experimental config * prompt * fix test * Update cy-prompt-development.md * Update cy-prompt-development.md * PR comments * Update packages/server/lib/cloud/api/cy-prompt/get_cy_prompt_bundle.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * PR comments --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * fix test * Delete packages/server/lib/cloud/StudioLifecycleManager.ts * Delete packages/server/test/unit/cloud/StudioLifecycleManager_spec.ts * chore: add cdp connection to cy prompt (#31806) * chore: add cdp connection to cy prompt * minor fix * fix type build * try to fix build * Update packages/server/lib/browsers/browser-cri-client.ts Co-authored-by: Bill Glesias <bglesias@gmail.com> * Update packages/server/lib/browsers/browser-cri-client.ts Co-authored-by: Bill Glesias <bglesias@gmail.com> * do not support prompt in firefox or webkit * rework timing of lifecycle * refactor * fix tests * troubleshooting * troubleshooting * fix tests * additional troubleshooting * additional troubleshooting * additional troubleshooting * attempt to fix build * add back * debugging * debugging * debugging * debugging * clean up * fix unit tests * rework --------- Co-authored-by: Bill Glesias <bglesias@gmail.com> * chore: create infrastructure to support backend function in cy.prompt (#31803) * chore: add promptBackend as an additional Cypress-attached function * Update packages/app/src/runner/event-manager.ts * update types * fix types * fix spacing * refactor * additional refactor * fix type build * fix build * refactor * reword messages * fix * debugging * undo debugging * PR comment * fix tests * fix tests * fix tests * fix test * chore: add watcher for cy-prompt development (#31810) * chore: add watcher for cy-prompt development * test caching * fix types * chore: turn on beta deployments for cy-prompt * internal: (cy.prompt) handle errors better in the command definition (#31835) * internal: (cy.prompt) handle errors better in the command definition * internal: (cy.prompt) add timeout and handle loading errors more cleanly * add process environment variable * clean up test * update JSDoc * chore: handle errors (#31854) * chore: handle errors * Fix ts, add test * Fix error title * Fix ts * Fix ts * chores: (cy.prompt) refactor routing to support both app and driver (#31891) * chore: Share error utils with the cloud (#31887) * share error utils with cloud * additional rework * Fix command, add isOpenMode * Add / fix test * fix ts --------- Co-authored-by: Ryan Manuel <ryanm@cypress.io> * internal: (cy.prompt) add infrastructure to support a Get Code modal (#31904) * chore: (cy.prompt) add infrastructure to support a Get Code modal * fix tests * fix code paths * Update eject button styles * handle errors * update types * Update packages/server/lib/socket-base.ts * Fix cy test * update readme --------- Co-authored-by: estrada9166 <estrada9166@gmail.com> * chore: (cy.prompt) refactor getTestsState to take a runnable id (#31965) * chore: (cy.prompt) refactor getTestsState to take a runnable id * fix tests * minor tweak * chore: (cy.prompt) add manifest for all of the cloud delivered files (#31922) * chore: (cy.prompt) add manifest for all of the cloud delivered files * fix tests and remove environment variables * update strategy * fix build * rework * require manifest * clean up * refactor * refactor * Update packages/server/lib/cloud/cy-prompt/CyPromptLifecycleManager.ts Co-authored-by: Matt Schile <mschile@cypress.io> * fix test --------- Co-authored-by: Matt Schile <mschile@cypress.io> * feat: add cy prompt more info needed modal (WIP) (#31970) * feat: add cy prompt more info needed modal * Reset promptStore * additional things exposed for more info * rework * fix tests * fix build * fix types * fix types * Update packages/app/src/runner/event-manager.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * reefactor * chore: (cy.prompt) rework the file save lifecycle * rework types * add unit tests --------- Co-authored-by: estrada9166 <estrada9166@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * fix: (cy.prompt) ensure that we do not attach a vue ref to the react root in the cy.prompt modals (#32011) * fix: (studio) ensure that we do not attach a vue ref to the react root in the studio panel * fix test * chore: Handle cy-prompt error to the cloud (#32009) Co-authored-by: Ryan Manuel <ryanm@cypress.io> * chore: display prompt error message (#32016) * add createCloudRequest to cloudApi, handle errors during createCyPromptServer * render the get code button on failure * chore: update types * chore: move CT and browser error to cloud (#32077) * feat: (cy.prompt) give cy.prompt access to recording information (#32110) * feat: (cy.prompt) give cy.prompt access to recording information * undo bad refactor * undo bad refactor * undo bad refactor * rename * fix typo * Update packages/server/test/unit/modes/record_spec.js * Update packages/server/test/unit/modes/record_spec.js * Update packages/server/test/unit/modes/record_spec.js * Update packages/server/test/unit/modes/record_spec.js * Update packages/server/test/unit/modes/record_spec.js * Update cy-prompt-development.md * Update cy-prompt-development.md * Update cy-prompt-development.md * chore: add CYPRESS_INTERNAL_SIMULATE_OPEN_MODE to simulate running Cypress tests in open mode (#32114) * chore: (cy.prompt) ensure to strip out paths from all data when reporting errors in prompt (#32134) * fix: (cy.prompt) ensure to strip out paths from all data when reporting errors in prompt * refactor * update tests * fix logic error with protocol * add event manager to get code * Apply suggestions from code review * fix: (cy.prompt) improve the get project options performance by running promises in parallel (#32196) * fix: (cy.prompt) improve the get project options performance by running promises in parallel * add awaits in test * bump cache * Update packages/server/lib/cloud/studio/StudioLifecycleManager.ts * fix build * chore: cleanup * blank * Update trigger-publish-binary-pipeline.js * Update packages/server/test/unit/socket_spec.js * get rid of environment variable * fix: (cy.prompt) ensure to reset the prompt state when the event manager is torn down (indicating that we're no longer on the runner page) (#32301) * fix: (cy.prompt) ensure to reset the prompt state when the event manager is torn down (indicating that we're no longer on the runner page) * move test * fix lint issue * feat: (cy.prompt) introduce the concept of log collapse state being open/closed by default (#32262) * feat: (cy.prompt) introduce the concept of logs' collapse state being open/closed by default * update tests * rename * PR comments * fix test due to bad merge of develop * chore: Only allow experimentalPromptCommand within e2e config (#32435) * chore: Only allow experimentalPromptCommand within e2e config * Fix config * Update tests * Update test, update types * Fix test and types * fix tests * Add types * Update cli/types/cypress.d.ts Co-authored-by: Ryan Manuel <ryanm@cypress.io> --------- Co-authored-by: Ryan Manuel <ryanm@cypress.io> * Update workflows.yml * Add optional cyPromptManagerPromise property * Implement error handling in CyPromptManager Added a new method to handle errors uniformly in CyPromptManager. * Fix indentation in socket_spec.js * fix: (cy.prompt) handle when the prompt is executed by in CT or when the experiment is not enabled (#32470) * fix: (cy.prompt) handle when the prompt is executed by in CT or when the experiment is not enabled * Update packages/driver/cypress/e2e/commands/prompt/prompt.cy.ts * Update packages/driver/cypress/e2e/commands/prompt/prompt.cy.ts * update name of errors * Bump cache version to 9-15-2025 * update yarn.lock * fixes * fix snapshot * fix snapshot * internal: fix get code button to be purple with correct margin (#32504) * feat: (cy.prompt) update the types of prompt (#32529) * fix: move currentMoreInfoNeededModalInfo.onCancel to onClose (#32559) * internal: (cy.prompt) various improvements to error messages and time outs (#32582) * internal: (cy.prompt) various improvements to error messages and timeouts * fix test * remove dead code * Update packages/driver/src/cy/commands/prompt/index.ts * update prompt experiment description * fix build * fix tests * fix tests * fix test * update error message * Update packages/server/lib/experiments.ts Co-authored-by: Tim Griesser <tgriesser10@gmail.com> --------- Co-authored-by: Tim Griesser <tgriesser10@gmail.com> * internal: (cy.prompt) ensure that get code can properly work with prompts in cy.origin (#32596) * internal: (cy.prompt) ensure that get code can properly work with prompts in cy.origin * additional tests * additional tests * Apply suggestions from code review * code review comment * fix merge * fix merge * Update packages/data-context/graphql/schemaTypes/index.ts * update workflow * blank * persist binaries * chore: display custom link title (#32567) * chore: display custom link title * Add test * Pass docs as second argument of the error * Revert changes * Use openExternal for links --------- Co-authored-by: Jennifer Shehane <jennifer@cypress.io> * update * internal: (cy.prompt) do not retry on cert failures (#32624) * internal: (cy.prompt) do not retry on cert failures * tests and clean up * additional cleanup and add error message for prompt * fix unit tests * Update report_studio_error.ts * Update packages/network/lib/agent.ts * cursor comment * fix build * fix build * fix test * fix build * fix build * fix build * fix build * fix build * revert * Update packages/driver/src/cypress/error_messages.ts * Update packages/driver/cypress/e2e/commands/prompt/prompt-initialization-error.cy.ts * fix build * cursor comment * add changelog entry * clean up * Update packages/app/src/store/prompt-store.ts * Bump cache version to 10-3-2025 Updated cache version to trigger CI cache recreation. * Revise CHANGELOG for new features and fixes Updated changelog with new features and bug fixes. * index on feat/cy-prompt: 3cbcf6c Bump cache version to 10-3-2025 * index on feat/cy-prompt: 3cbcf6c Bump cache version to 10-3-2025 * index on feat/cy-prompt: 3cbcf6c Bump cache version to 10-3-2025 * blank * fix build --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Bill Glesias <bglesias@gmail.com> Co-authored-by: Alejandro Estrada <estrada9166@gmail.com> Co-authored-by: Matt Schile <mschile@cypress.io> Co-authored-by: Tim Griesser <tgriesser10@gmail.com> Co-authored-by: Jennifer Shehane <jennifer@cypress.io> Co-authored-by: Jennifer Shehane <shehane.jennifer@gmail.com> Co-authored-by: cypress-bot[bot] <+cypress-bot[bot]@users.noreply.github.com>
Additional details
This PR creates an infrastructure to communicate to the backend within the cloud-delivered
cy-prompt
code. It is modeled afterCypress.backend
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation
?type definitions
?